SPDY: Add WriteHeaders interface to SpdySession and SpdyStream

net/spdy/spdy_stream.h

Index: net/spdy/spdy_stream.h
diff --git a/net/spdy/spdy_stream.h b/net/spdy/spdy_stream.h
index 8653d9fde6fecfdd8b80bffe6ed0878a90b2c600..91655e403be7dbda298e05de5f74afece313b21e 100644
--- a/net/spdy/spdy_stream.h
+++ b/net/spdy/spdy_stream.h
@@ -88,6 +88,8 @@ class NET_EXPORT_PRIVATE SpdyStream
     DISALLOW_COPY_AND_ASSIGN(Delegate);
   };
 
+  typedef std::pair<SpdyHeaderBlock*, SpdyDataFrame*> PendingFrame;

[Ryan Hamilton, 2012/07/31 15:46:24]

Instead of storing a pair of pointers, how about storing the two pointers in a
union and using a boolen (or an enum) to determine which one is valid.

[Takashi Toyoshima, 2012/08/01 13:40:00]

Thanks.
That's nice. I can remove complicated DCHECK(!headers != !data_frame) from my
change :-)

+
   // SpdyStream constructor
   SpdyStream(SpdySession* session,
              bool pushed,
@@ -222,6 +224,10 @@ class NET_EXPORT_PRIVATE SpdyStream
   // For non push stream, it will send SYN_STREAM frame.
   int SendRequest(bool has_upload_data);
 
+  // Sends a HEADERS frame. SpdyStream owns |headers| and will release it after
+  // the HEADERS frame is actually sent.
+  int WriteHeaders(SpdyHeaderBlock* headers);
+
   // Sends DATA frame.
   int WriteStreamData(IOBuffer* data, int length,
                       SpdyDataFlags flags);
@@ -345,7 +351,7 @@ class NET_EXPORT_PRIVATE SpdyStream
   scoped_ptr<SpdyHeaderBlock> response_;
   base::Time response_time_;
 
-  std::list<SpdyFrame*> pending_data_frames_;
+  std::list<PendingFrame> pending_data_frames_;
 
   State io_state_;