Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_unittest.cc

Issue 10810062: Moving common code into OmniboxView from OmniboxView* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix final nits Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.cc ('k') | chrome/browser/ui/omnibox/omnibox_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/omnibox_edit_unittest.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_unittest.cc b/chrome/browser/ui/omnibox/omnibox_edit_unittest.cc
index a5958d1bf5de453c303a93ca523b37e04e0cfb61..2892ce0779dc2e3dfd0e55c7cdecb3161237544d 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_unittest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_edit_unittest.cc
@@ -20,10 +20,8 @@ namespace {
class TestingOmniboxView : public OmniboxView {
public:
- TestingOmniboxView() {}
+ TestingOmniboxView() : OmniboxView(NULL, NULL, NULL, NULL) {}
- virtual OmniboxEditModel* model() OVERRIDE { return NULL; }
- virtual const OmniboxEditModel* model() const OVERRIDE { return NULL; }
virtual void SaveStateToTab(WebContents* tab) OVERRIDE {}
virtual void Update(const WebContents* tab_for_state_restoring) OVERRIDE {}
virtual void OpenMatch(const AutocompleteMatch& match,
@@ -31,9 +29,6 @@ class TestingOmniboxView : public OmniboxView {
const GURL& alternate_nav_url,
size_t selected_line) OVERRIDE {}
virtual string16 GetText() const OVERRIDE { return string16(); }
- virtual bool IsEditingOrEmpty() const OVERRIDE { return true; }
- virtual int GetIcon() const OVERRIDE { return 0; }
- virtual void SetUserText(const string16& text) OVERRIDE {}
virtual void SetUserText(const string16& text,
const string16& display_text,
bool update_popup) OVERRIDE {}
@@ -48,7 +43,6 @@ class TestingOmniboxView : public OmniboxView {
virtual void SelectAll(bool reversed) OVERRIDE {}
virtual void RevertAll() OVERRIDE {}
virtual void UpdatePopup() OVERRIDE {}
- virtual void ClosePopup() OVERRIDE {}
virtual void SetFocus() OVERRIDE {}
virtual void OnTemporaryTextMaybeChanged(
const string16& display_text,
@@ -64,7 +58,6 @@ class TestingOmniboxView : public OmniboxView {
virtual gfx::NativeView GetRelativeWindowForPopup() const OVERRIDE {
return NULL;
}
- virtual CommandUpdater* GetCommandUpdater() OVERRIDE { return NULL; }
virtual void SetInstantSuggestion(const string16& input,
bool animate_to_complete) OVERRIDE {}
virtual string16 GetInstantSuggestion() const OVERRIDE { return string16(); }
@@ -83,6 +76,9 @@ class TestingOmniboxView : public OmniboxView {
virtual int WidthOfTextAfterCursor() { return 0; }
#endif
+ virtual int GetOmniboxTextLength() const OVERRIDE { return 0; }
+ virtual void EmphasizeURLComponents() OVERRIDE { }
+
private:
DISALLOW_COPY_AND_ASSIGN(TestingOmniboxView);
};
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.cc ('k') | chrome/browser/ui/omnibox/omnibox_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698