Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10810053: Enables internal filesystem types via Isolated filesystems (Closed)

Created:
8 years, 5 months ago by kinuko
Modified:
8 years, 5 months ago
Reviewers:
kmadhusu, tzik
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, oshima+watch_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, nhiroki (google), Lei Zhang
Visibility:
Public.

Description

Enables internal filesystem types via Isolated filesystems. * cracks isolated path in FileSystemURL ctor * FileUtils no longer need to crack the isolated path by themselves * Make IsolatedFileUtil inherit from LocalFileUtil * Have a separate FileUtil for DraggedFileUtil, which inherits from IsolatedFileUtil BUG=134078, 138022 TEST=existing tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148440

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase + call CrackIsolatedPath in FileSystemURL ctor #

Patch Set 3 : layout test crash fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -407 lines) Patch
M content/browser/fileapi/fileapi_message_filter.cc View 1 2 chunks +5 lines, -12 lines 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/chromeos/fileapi/cros_mount_point_provider.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_context.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_mount_point_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/file_system_quota_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_url.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M webkit/fileapi/file_system_url.cc View 1 4 chunks +15 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_url_request_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/fileapi/isolated_context.h View 1 1 chunk +3 lines, -6 lines 0 comments Download
M webkit/fileapi/isolated_context.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/fileapi/isolated_context_unittest.cc View 1 2 chunks +7 lines, -9 lines 0 comments Download
M webkit/fileapi/isolated_file_util.h View 1 3 chunks +18 lines, -65 lines 0 comments Download
M webkit/fileapi/isolated_file_util.cc View 1 6 chunks +43 lines, -227 lines 0 comments Download
M webkit/fileapi/isolated_file_util_unittest.cc View 1 10 chunks +22 lines, -24 lines 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.h View 3 chunks +3 lines, -1 line 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.cc View 1 3 chunks +20 lines, -39 lines 0 comments Download
M webkit/fileapi/local_file_system_test_helper.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M webkit/fileapi/local_file_system_test_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/local_file_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/test_mount_point_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/test_mount_point_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kmadhusu
http://codereview.chromium.org/10810053/diff/1/chrome/browser/intents/device_attached_intent_source.cc File chrome/browser/intents/device_attached_intent_source.cc (right): http://codereview.chromium.org/10810053/diff/1/chrome/browser/intents/device_attached_intent_source.cc#newcode52 chrome/browser/intents/device_attached_intent_source.cc:52: fileapi::kFileSystemTypeMedia, device_path, &device_name); Let the initial changes specify the ...
8 years, 5 months ago (2012-07-24 22:02:12 UTC) #1
kinuko
http://codereview.chromium.org/10810053/diff/1/chrome/browser/intents/device_attached_intent_source.cc File chrome/browser/intents/device_attached_intent_source.cc (right): http://codereview.chromium.org/10810053/diff/1/chrome/browser/intents/device_attached_intent_source.cc#newcode52 chrome/browser/intents/device_attached_intent_source.cc:52: fileapi::kFileSystemTypeMedia, device_path, &device_name); On 2012/07/24 22:02:12, kmadhusu wrote: > ...
8 years, 5 months ago (2012-07-25 17:46:31 UTC) #2
kinuko
Ok now it's in a better shape. Could you take a look?
8 years, 5 months ago (2012-07-25 17:47:45 UTC) #3
tzik
8 years, 5 months ago (2012-07-25 21:25:55 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698