Modify image for mfg test, e.g. copying qualified component file to the image.

Modify image for mfg test, e.g. copying qualified component file to the image.

[petkov, 2010-03-18 23:46:52]

kmixter and sosa can review this one...

[sosa, 2010-03-18 23:58:45]

http://codereview.chromium.org/1081002/diff/3001/4001
File src/scripts/mod_image_for_test.sh (right):

http://codereview.chromium.org/1081002/diff/3001/4001#newcode106
src/scripts/mod_image_for_test.sh:106: if [ $FLAGS_mfgtest -eq $FLAGS_TRUE ];
then
be consistent with your use of {} around variables and not. I suggest using {}
since most of the rest of script has it

http://codereview.chromium.org/1081002/diff/3001/4001#newcode110
src/scripts/mod_image_for_test.sh:110: if [ -z $FLAGS_qualdb ]; then
Just use $FLAGS_qualdb and not bring in another variable

http://codereview.chromium.org/1081002/diff/3001/4001#newcode112
src/scripts/mod_image_for_test.sh:112: QUAL_DB=$(ls -dt $RESULT_DIR 2>&-| head
-1)
You could move this up and set as the default for the flag

http://codereview.chromium.org/1081002/diff/3001/4001#newcode120
src/scripts/mod_image_for_test.sh:120:
${QUAL_DB}/platform_Components,*/platform_Components/results/system_components)
What happens if you get more than one entry back?  Seems like it's easier to
just require them to give you the file

http://codereview.chromium.org/1081002/diff/3001/4001#newcode126
src/scripts/mod_image_for_test.sh:126: sudo mkdir -p
${ROOT_FS_DIR}/usr/local/manufacturing
Fine for now, will make change later once /usr/local is on stateful.

[kmixter1, 2010-03-19 00:12:45]

Adding Nick as he is looking at adding autotest client to the image similarly.

[sosa, 2010-03-19 23:15:31]

lgtm