Chromium Code Reviews| Index: chrome/browser/extensions/menu_manager.cc |
| diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc |
| index e599f3bd238cfba0ce9ff0075d3ee8f225ea2500..fd506a93044f51725765d7863df4607c0ebf9fa2 100644 |
| --- a/chrome/browser/extensions/menu_manager.cc |
| +++ b/chrome/browser/extensions/menu_manager.cc |
| @@ -268,6 +268,24 @@ bool MenuItem::PopulateURLPatterns(const DictionaryValue& properties, |
| return true; |
| } |
| +bool MenuItem::PopulateURLPatterns(ListValue* document_url_patterns, |
| + ListValue* target_url_patterns, |
| + std::string* error) { |
|
not at google - send to devlin
2012/07/26 04:16:20
When you convert these to taking vectors, you coul
chebert
2012/07/27 01:28:24
Done.
|
| + if (document_url_patterns) { |
| + if (!document_url_patterns_.Populate( |
| + *document_url_patterns, URLPattern::SCHEME_ALL, true, error)) { |
| + return false; |
| + } |
| + } |
| + if (target_url_patterns) { |
| + if (!target_url_patterns_.Populate( |
| + *target_url_patterns, URLPattern::SCHEME_ALL, true, error)) { |
| + return false; |
| + } |
| + } |
| + return true; |
| +} |
| + |
| MenuManager::MenuManager(Profile* profile) |
| : profile_(profile) { |
| registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED, |