Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/menu_manager.h

Issue 10809094: Context Menus now uses the JSON Schema Compiler. (Closed) Base URL: http://git.chromium.org/chromium/src.git@json_functions_as_properties
Patch Set: made some minor changes Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/context_menu/context_menu_api.cc ('K') | « chrome/browser/extensions/api/context_menu/context_menu_api.cc ('k') | chrome/browser/extensions/menu_manager.cc » ('j') | chrome/browser/extensions/menu_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/menu_manager.h
diff --git a/chrome/browser/extensions/menu_manager.h b/chrome/browser/extensions/menu_manager.h
index 54445a01fb09ce1fc4cf5875bbed86c1f67c53ee..9ffe0fcf66004829e2b5d2452b3ae2f082eab48d 100644
--- a/chrome/browser/extensions/menu_manager.h
+++ b/chrome/browser/extensions/menu_manager.h
@@ -181,9 +181,8 @@ class MenuItem {
std::string* error);
// Sets any document and target URL patterns from |properties|.
- bool PopulateURLPatterns(const base::DictionaryValue& properties,
- const char* document_url_patterns_key,
- const char* target_url_patterns_key,
+ bool PopulateURLPatterns(std::vector<std::string>* document_url_patterns,
+ std::vector<std::string>* target_url_patterns,
std::string* error);
protected:
« chrome/browser/extensions/api/context_menu/context_menu_api.cc ('K') | « chrome/browser/extensions/api/context_menu/context_menu_api.cc ('k') | chrome/browser/extensions/menu_manager.cc » ('j') | chrome/browser/extensions/menu_manager_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698