Context Menus now uses the JSON Schema Compiler.

chrome/browser/extensions/menu_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/menu_manager.h"
 
 #include <algorithm>
 
 #include "base/json/json_writer.h"
 #include "base/logging.h"
@@ skipping 245 matching lines @@
       return false;
     }
   }
   if (properties.HasKey(target_url_patterns_key)) {
     const ListValue* list = NULL;
     if (!properties.GetList(target_url_patterns_key, &list))
       return false;
     if (!target_url_patterns_.Populate(
             *list, URLPattern::SCHEME_ALL, true, error)) {
       return false;
     }

[not at google - send to devlin, 2012/08/06 01:55:45]

plz just convert these to vectors and pass in PopulateURLParameters. Minimise
code duplication and you minimise the chances of subtle errors.

[chebert, 2012/08/06 03:38:04]

Umm. Sorry I think I patched from the wrong branch or something, because I spent
some quite a bit of time doing this.

This is embarrassing.

On 2012/08/06 01:55:45, kalman wrote:

[not at google - send to devlin, 2012/08/06 03:58:42]

No probs :)

   }
   return true;
 }
 
+bool MenuItem::PopulateURLPatterns(
+    std::vector<std::string>* document_url_patterns,
+    std::vector<std::string>* target_url_patterns,
+    std::string* error) {
+  if (document_url_patterns) {
+    if (!document_url_patterns_.Populate(
+            *document_url_patterns, URLPattern::SCHEME_ALL, true, error)) {
+      return false;
+    }
+  }
+  if (target_url_patterns) {
+    if (!target_url_patterns_.Populate(
+            *target_url_patterns, URLPattern::SCHEME_ALL, true, error)) {
+      return false;
+    }
+  }
+  return true;
+}
+
 MenuManager::MenuManager(Profile* profile)
     : profile_(profile) {
   registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED,
                  content::Source<Profile>(profile));
   registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,
                  content::Source<Profile>(profile));
 
   StateStore* store = ExtensionSystem::Get(profile_)->state_store();
   if (store)
     store->RegisterKey(kContextMenusKey);
@@ skipping 536 matching lines @@
       if (uid < other.uid)
         return true;
       if (uid == other.uid)
         return string_uid < other.string_uid;
     }
   }
   return false;
 }
 
 }  // namespace extensions