Issue 10809051: Fix regression of bug 205 where a plugin in a window shown with window.open may not have the correc…

Issue 10809051: Fix regression of bug 205 where a plugin in a window shown with window.open may not have the correc… (Closed)

Created:
8 years, 5 months ago by jam

Modified:
8 years, 5 months ago

Reviewers:
ananta

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Fix regression of bug 205 where a plugin in a window shown with window.open may not have the correct parent window. PluginTest.OpenPopupWindowWithPlugin covers this, but this bug is a race condition which is why the test works most of the time (although it shows up on the flakiness dashboard). When I tried to move this test to content_browsertests, the timing was different so it showed up most of the time. BUG=205 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147874

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -13 lines)			Patch
M	content/browser/renderer_host/render_process_host_impl.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1	1 chunk	+5 lines, -0 lines	2 comments	Download
M	content/browser/renderer_host/render_widget_helper.h	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_helper.cc	View	1	3 chunks	+13 lines, -12 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/browser/render_process_host.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/public/test/mock_render_process_host.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/test/mock_render_process_host.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ananta

lgtm http://codereview.chromium.org/10809051/diff/5013/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (right): http://codereview.chromium.org/10809051/diff/5013/content/browser/renderer_host/render_process_host_impl.cc#newcode1137 content/browser/renderer_host/render_process_host_impl.cc:1137: Remove extra newline.

8 years, 5 months ago (2012-07-23 17:04:44 UTC) #2

jam

8 years, 5 months ago (2012-07-23 17:34:32 UTC) #3

http://codereview.chromium.org/10809051/diff/5013/content/browser/renderer_ho...
File content/browser/renderer_host/render_process_host_impl.cc (right):

http://codereview.chromium.org/10809051/diff/5013/content/browser/renderer_ho...
content/browser/renderer_host/render_process_host_impl.cc:1137: 
On 2012/07/23 17:04:44, ananta wrote:
> Remove extra newline.

Done.

Expand Messages | Collapse Messages