Run media_unittests on android test bots.

media/base/run_all_unittests.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/test/test_suite.h"
 #include "media/base/media.h"
 
 class TestSuiteNoAtExit : public base::TestSuite {
  public:
-  TestSuiteNoAtExit(int argc, char** argv) : TestSuite(argc, argv, false) {}
+  TestSuiteNoAtExit(int argc, char** argv) : TestSuite(argc, argv, true) {}

[Ami GONE FROM CHROMIUM, 2012/07/25 23:06:01]

s/, true// instead?

[nilesh, 2012/07/26 00:54:02]

Done.

   virtual ~TestSuiteNoAtExit() {}
+ protected:
+  virtual void Initialize();
 };
 
+void TestSuiteNoAtExit::Initialize() {
+  // Run TestSuite::Initialize first so that logging in initialized.

[Ami GONE FROM CHROMIUM, 2012/07/25 23:06:01]

s/in/is/

[nilesh, 2012/07/26 00:54:02]

Done.

+  base::TestSuite::Initialize();
+  media::InitializeMediaLibraryForTesting();

[Ami GONE FROM CHROMIUM, 2012/07/25 23:06:01]

It's strange-looking that this will be called multiple times, but luckily it's a
no-op after the first time.

How about a comment:
// Run this here instead of main() to ensure an AtExitManager is already
present.
?

[nilesh, 2012/07/26 00:54:02]

Maybe I am missing something, but Initialize is called only once and hence
media::InitializeMediaLibraryForTesting() will also be called only once ?
Done.

[Ami GONE FROM CHROMIUM, 2012/07/26 04:01:11]

I was thinking of gtest's SetUp method, which is called for each test case, but
that's not what this is.  Never mind.

+}
+
 int main(int argc, char** argv) {
-  // By default command-line parsing happens only in TestSuite::Run(), but

[nilesh, 2012/07/25 21:56:32]

I think this can be removed now.
TestSuite ctor calls PreInitialize which inits the command line.
TestSuite::Run() calls Initialize() and we setup logging in
TestSuite::Initialize() before media::InitializeMediaLibraryForTesting() is
called. 

Arguments passed to InitLogging are slightly different here, but it looks like
they are such to avoid any side effects.
Let me know if my understanding is wrong.

-  // that's too late to get VLOGs and so on from
-  // InitializeMediaLibraryForTesting() below.  Instead initialize logging
-  // explicitly here (and have it get re-initialized by TestSuite::Run()).
-  CommandLine::Init(argc, argv);
-  CHECK(logging::InitLogging(
-      NULL,
-      logging::LOG_ONLY_TO_SYSTEM_DEBUG_LOG,
-      logging::DONT_LOCK_LOG_FILE,
-      logging::APPEND_TO_OLD_LOG_FILE,
-      logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS));
-  base::AtExitManager exit_manager;
-
-  media::InitializeMediaLibraryForTesting();
-
   return TestSuiteNoAtExit(argc, argv).Run();
 }