chrome/test/data/extensions/api_test/notifications/has_permission_manifest/background.js - Issue 10808113: Only allows extensions to create HTML notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/notifications/has_permission_manifest/background.js

Issue 10808113: Only allows extensions to create HTML notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix per feedback Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/notifications/has_not_permission/notification.html ('k') | chrome/test/data/extensions/api_test/notifications/has_permission_prefs/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/notifications/has_permission_manifest/background.js

diff --git a/chrome/test/data/extensions/api_test/notifications/has_permission_manifest/background.js b/chrome/test/data/extensions/api_test/notifications/has_permission_manifest/background.js

index 9bc585a6031837da4ea33752774689cbf6f3134a..79fb80a6e6cf1da47f520094ed9c9a4d8601f5b4 100644

--- a/chrome/test/data/extensions/api_test/notifications/has_permission_manifest/background.js

+++ b/chrome/test/data/extensions/api_test/notifications/has_permission_manifest/background.js

@@ -26,11 +26,9 @@ function onNotificationDone() {

if (changeInfo.status != 'complete')

return;

// web_page1 loaded, open extension page to inject script

- if (tab.url == chromeExtensionsUrl) {

- console.log(chromeExtensionsUrl + ' finished loading.');

- chrome.tabs.onUpdated.removeListener(listener);

- chrome.test.succeed();

- }

+ console.log(chromeExtensionsUrl + ' finished loading.');

+ chrome.tabs.onUpdated.removeListener(listener);

+ chrome.test.succeed();

};

chrome.tabs.onUpdated.addListener(listener);