chrome/test/data/extensions/api_test/notifications/has_not_permission/background.js - Issue 10808113: Only allows extensions to create HTML notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/notifications/has_not_permission/background.js

Issue 10808113: Only allows extensions to create HTML notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix per feedback Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/chrome_render_view_observer.cc ('k') | chrome/test/data/extensions/api_test/notifications/has_not_permission/notification.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/notifications/has_not_permission/background.js

diff --git a/chrome/test/data/extensions/api_test/notifications/has_not_permission/background.js b/chrome/test/data/extensions/api_test/notifications/has_not_permission/background.js

index dd415018bac3f528dc9a2883366a881fa5fb6079..1a4ee94d7b10bae8ff4f260b0f5663b84ce19c64 100644

--- a/chrome/test/data/extensions/api_test/notifications/has_not_permission/background.js

+++ b/chrome/test/data/extensions/api_test/notifications/has_not_permission/background.js

@@ -8,10 +8,17 @@ chrome.test.runTests([

webkitNotifications.checkPermission());

chrome.test.succeed();

- function showNotification() {

+ function showHTMLNotification() {

+ // createHTMLNotification should not be exposed.

+ if (window.webkitNotifications.createHTMLNotification)

+ chrome.test.fail("createHTMLNotification is found.");

+ else

+ chrome.test.succeed();

+ },

+ function showTextNotification() {

try {

- window.webkitNotifications.createHTMLNotification(

- chrome.extension.getURL("notification.html")).show();

+ window.webkitNotifications.createNotification(

+ "", "Foo", "This is text notification.").show();

} catch (e) {

chrome.test.assertTrue(e.message.indexOf("SECURITY_ERR") == 0);

chrome.test.succeed();