[NaCl SDK] Clean up build_sdk.py

[NaCl SDK] Clean up build_sdk.py

BUG=none
TEST=none
R=noelallen@chromium.org
NOTRY=true


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148233

[binji, 2012-07-24 18:04:04]

Mostly just factored out a bunch of smaller functions. Other changes are
described below.

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
File native_client_sdk/src/build_tools/build_sdk.py (right):

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:560: archive.url = archive_url
changed this to use the manifest_util properties. The original was written
before they existed.

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:564: bundle =
manifest_util.Bundle('pepper_' + pepper_ver)
here too

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:676: def
BuildStepArchiveSDKTools():
This used to be part of the BuildStepArchiveBundle above, I separated it out.

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:741: tarfile =
os.path.join(SERVER_DIR, tarname)
I write the tarfile directly into the local server directory now. It used to be
written to OUT_DIR and then immediately moved to SERVER_DIR.

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:748:
BuildStepCopyExamples(pepperdir, toolchains)
This is duplicated below, but I think this makes the '--examples' flag much
clearer.

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:755: BuildStepBuildToolsTests()
I moved this suite of tests first. It is unrelated to everything that happens
below, really... it seemed weird to be in the middle of everything else.

[noelallen1, 2012-07-24 20:48:24]

Small nits, LGTM

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
File native_client_sdk/src/build_tools/build_sdk.py (right):

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:534: 
I should've added a comment:
   make clean to remove temp files while keeping libs.

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:770: if not options.skip_tar:
I think by default we want to skip_tar on example builds.  I suppose we could
just CTRL-C out if we run it accidentally..

[binji, 2012-07-24 22:46:15]

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
File native_client_sdk/src/build_tools/build_sdk.py (right):

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:534: 
On 2012/07/24 20:48:24, noelallen1 wrote:
> I should've added a comment:
>    make clean to remove temp files while keeping libs.

Done.

http://codereview.chromium.org/10808103/diff/1/native_client_sdk/src/build_to...
native_client_sdk/src/build_tools/build_sdk.py:770: if not options.skip_tar:
On 2012/07/24 20:48:24, noelallen1 wrote:
> I think by default we want to skip_tar on example builds.  I suppose we could
> just CTRL-C out if we run it accidentally..

The example build is handled as a special case above:
"if options.only_examples:"

[commit-bot: I haz the power, 2012-07-24 22:46:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/10808103/5001

[commit-bot: I haz the power, 2012-07-24 22:47:01]

Change committed as 148233