Always use chromium threads for IO in remoting host

Always use chromium threads for IO in remoting host

BUG=137140
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148418

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148803

[Wez, 2012-07-25 10:26:27]

lgtm

http://codereview.chromium.org/10808094/diff/1/remoting/jingle_glue/xmpp_sign...
File remoting/jingle_glue/xmpp_signal_strategy.cc (right):

http://codereview.chromium.org/10808094/diff/1/remoting/jingle_glue/xmpp_sign...
remoting/jingle_glue/xmpp_signal_strategy.cc:81: socket_factory.release(),
kReadBufferSize, kWriteBufferSize);
Isn't it a waste of resources to have a separate factory per socket?

[Sergey Ulanov, 2012-07-25 18:50:49]

http://codereview.chromium.org/10808094/diff/1/remoting/jingle_glue/xmpp_sign...
File remoting/jingle_glue/xmpp_signal_strategy.cc (right):

http://codereview.chromium.org/10808094/diff/1/remoting/jingle_glue/xmpp_sign...
remoting/jingle_glue/xmpp_signal_strategy.cc:81: socket_factory.release(),
kReadBufferSize, kWriteBufferSize);
On 2012/07/25 10:26:27, Wez wrote:
> Isn't it a waste of resources to have a separate factory per socket?

We never need more than one XmppSignalStrategy, so it doesn't matter here.

[commit-bot: I haz the power, 2012-07-25 19:14:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10808094/9001

[commit-bot: I haz the power, 2012-07-25 21:43:24]

Change committed as 148418

[commit-bot: I haz the power, 2012-07-27 19:13:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10808094/18001

[commit-bot: I haz the power, 2012-07-27 19:14:09]

Failed to apply patch for remoting/protocol/libjingle_transport_factory.cc:
While running patch -p1 --forward --force;
patching file remoting/protocol/libjingle_transport_factory.cc
Hunk #2 FAILED at 312.
1 out of 2 hunks FAILED -- saving rejects to file
remoting/protocol/libjingle_transport_factory.cc.rej

[commit-bot: I haz the power, 2012-07-27 19:19:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10808094/5033

[commit-bot: I haz the power, 2012-07-27 21:01:27]

Failed to apply the patch.
Sending        remoting/host/chromoting_host_context.cc
Sending        remoting/host/chromoting_host_context.h
Sending        remoting/host/chromoting_host_context_unittest.cc
Sending        remoting/host/heartbeat_sender.cc
Sending        remoting/host/host_mock_objects.h
Sending        remoting/host/host_port_allocator.cc
Sending        remoting/host/log_to_server.cc
Sending        remoting/host/plugin/host_script_object.cc
Sending        remoting/host/register_support_host_request.cc
Sending        remoting/host/remoting_me2me_host.cc
Sending        remoting/host/simple_host_process.cc
Sending        remoting/host/url_request_context.cc
Deleting       remoting/jingle_glue/jingle_thread.cc
Deleting       remoting/jingle_glue/jingle_thread.h
Deleting       remoting/jingle_glue/jingle_thread_unittest.cc
Deleting       remoting/jingle_glue/ssl_adapter.cc
Deleting       remoting/jingle_glue/ssl_adapter.h
Deleting       remoting/jingle_glue/ssl_socket_adapter.cc
Deleting       remoting/jingle_glue/ssl_socket_adapter.h
Sending        remoting/jingle_glue/xmpp_signal_strategy.cc
Sending        remoting/jingle_glue/xmpp_signal_strategy.h
Deleting       remoting/jingle_glue/xmpp_socket_adapter.cc
Deleting       remoting/jingle_glue/xmpp_socket_adapter.h
Sending        remoting/protocol/jingle_session_unittest.cc
Sending        remoting/protocol/libjingle_transport_factory.cc
Sending        remoting/protocol/libjingle_transport_factory.h
Sending        remoting/remoting.gyp
Transmitting file data ..................svn: Commit failed (details follow):
svn: File '/trunk/src/remoting/host/chromoting_host_context.cc' is out of date