move openMediaGalleryManager fn out of experimental.

chrome/test/data/extensions/api_test/media_galleries/test.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-var mediaGalleries = chrome.experimental.mediaGalleries;
-var mediaFileSystemsListCallback = function(results) {
-  // There should be a "Pictures" directory on all desktop platforms.
-  var expectedFileSystems = 1;
-  // But not on Android and ChromeOS.
-  if (/Android/.test(navigator.userAgent) || /CrOS/.test(navigator.userAgent)) {
-    expectedFileSystems = 0;
+chrome.experimental.app.onLaunched.addListener(function() {
+  var experimentalMediaGalleries = chrome.experimental.mediaGalleries;
+  var mediaGalleries = chrome.mediaGalleries;
+  var mediaFileSystemsListCallback = function(results) {
+    // There should be a "Pictures" directory on all desktop platforms.
+    var expectedFileSystems = 1;
+    // But not on Android and ChromeOS.
+    if (/Android/.test(navigator.userAgent) || /CrOS/.test(navigator.userAgent))
+      expectedFileSystems = 0;
+    chrome.test.assertEq(expectedFileSystems, results.length);
+    // TODO(vandebo) Test that we can read from the file system object.
+  };
+  var nullCallback = function(result) {
+    chrome.test.assertEq(null, result);
+  };
+
+  function runTests(tests) {
+    chrome.test.getConfig(function(config) {
+      operatingSystem = config.osName;
+      chrome.test.runTests(tests);

[not at google - send to devlin, 2012/07/24 04:56:21]

I can see the code was already like this... but having multiple calls to
chrome.test.runTests is kind of dangerous, since it assumes it only ever gets
called once (look in apitest.js).

That said, am I going crazy, or does this function never even get called?

[Evan Stade, 2012/07/24 17:31:33]

yea, I think you are right. It still passes locally if I remove it, but I'll add
a TODO to remove it for now just because I want to land this without another
pass by the trybots.

+    });
   }
-  chrome.test.assertEq(expectedFileSystems, results.length);
-  // TODO(vandebo) Test that we can read from the file system object.
-};
-var nullCallback = function(result) {
-  chrome.test.assertEq(null, result);
-};
 
-function runTests(tests) {
-  chrome.test.getConfig(function(config) {
-    operatingSystem = config.osName;
-    chrome.test.runTests(tests);
-  });
-}
+  chrome.test.runTests([
+    function getGalleries() {
+      mediaGalleries.getMediaFileSystems(
+          chrome.test.callbackPass(mediaFileSystemsListCallback));
+    },
 
-chrome.test.runTests([
-  function getGalleries() {
-    mediaGalleries.getMediaFileSystems(
-        chrome.test.callbackPass(mediaFileSystemsListCallback));
-  },
+    function extractEmbeddedThumbnails() {
+      var result = experimentalMediaGalleries.extractEmbeddedThumbnails({});

[vandebo (ex-Chrome), 2012/07/24 04:07:05]

We could test experimental APIs in a different test file.

+      chrome.test.assertEq(null, result);
+      chrome.test.succeed();
+    },
 
-  function extractEmbeddedThumbnails() {
-    var result = mediaGalleries.extractEmbeddedThumbnails({});
-    chrome.test.assertEq(null, result);
-    chrome.test.succeed();
-  },
-
-  function assembleMediaFile() {
-    mediaGalleries.assembleMediaFile(
-        new Blob, {},
-        chrome.test.callbackPass(nullCallback));
-  },
-]);
+    function assembleMediaFile() {
+      experimentalMediaGalleries.assembleMediaFile(
+          new Blob, {},
+          chrome.test.callbackPass(nullCallback));
+    },
+  ]);
+});