Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 10808092: Add settings UI for managing defaults (Closed)

Created:
8 years, 5 months ago by Steve McKay
Modified:
8 years, 3 months ago
Reviewers:
groby-ooo-7-16, csilv
CC:
chromium-reviews, arv (Not doing code reviews)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add new "Manage preferred service..." button to web intents settings UI. Update message naming to use common naming pattern. BUG=137907

Patch Set 1 #

Patch Set 2 : Update to display only service URL and matcher. Cannot delete now, pending other changes to registr… #

Patch Set 3 : Add UMA reporting for "remove default". #

Patch Set 4 : Cleanups from self-review. #

Patch Set 5 : Add commented out code for "unregister". #

Patch Set 6 : Move localized string reg to right class. #

Patch Set 7 : Perform idiomatic registration of overlay title. #

Patch Set 8 : #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+425 lines, -11 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +13 lines, -1 line 0 comments Download
M chrome/browser/resources/options2/content_settings.html View 1 2 3 1 chunk +14 lines, -7 lines 1 comment Download
M chrome/browser/resources/options2/content_settings.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/options.html View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/options.js View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/options_bundle.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options2/options_page.js View 1 2 3 1 chunk +1 line, -0 lines 1 comment Download
A chrome/browser/resources/options2/web_intents_defaults.css View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/browser/resources/options2/web_intents_defaults.html View 1 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/resources/options2/web_intents_defaults.js View 1 1 chunk +49 lines, -0 lines 1 comment Download
A chrome/browser/resources/options2/web_intents_defaults_list.js View 1 2 3 1 chunk +78 lines, -0 lines 1 comment Download
M chrome/browser/ui/webui/options2/content_settings_handler.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 1 comment Download
M chrome/browser/ui/webui/options2/options_ui.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/options2/web_intents_defaults_handler.h View 1 2 3 1 chunk +48 lines, -0 lines 1 comment Download
A chrome/browser/ui/webui/options2/web_intents_defaults_handler.cc View 1 2 3 4 5 6 7 1 chunk +142 lines, -0 lines 4 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/tools/chromeactions.txt View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Steve McKay
This CL depends on 10824212 which is currently being committed. So there's one line of ...
8 years, 4 months ago (2012-08-08 21:41:18 UTC) #1
Steve McKay
Assigning to Chris since Dan isn't available.
8 years, 4 months ago (2012-08-08 22:46:38 UTC) #2
csilv
http://codereview.chromium.org/10808092/diff/5003/chrome/browser/resources/options2/content_settings.html File chrome/browser/resources/options2/content_settings.html (right): http://codereview.chromium.org/10808092/diff/5003/chrome/browser/resources/options2/content_settings.html#newcode254 chrome/browser/resources/options2/content_settings.html:254: <h3 i18n-content="web_intents_tab_label" Although this rule isn't followed consistently, we ...
8 years, 4 months ago (2012-08-09 18:18:04 UTC) #3
Steve McKay
8 years, 3 months ago (2012-08-30 16:19:42 UTC) #4
This appears to be officially dead now. Closing.

Powered by Google App Engine
This is Rietveld 408576698