Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: printing/backend/print_backend_cups.cc

Issue 10808086: Standardize log message style for cloudprint service and display printer id (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/backend/print_backend_cups.cc
diff --git a/printing/backend/print_backend_cups.cc b/printing/backend/print_backend_cups.cc
index db606c8484d501ed3f4261b1029ddb48bfc07b63..87aaf94d46cf2815dbf797f3d297169cd01586c8 100644
--- a/printing/backend/print_backend_cups.cc
+++ b/printing/backend/print_backend_cups.cc
@@ -146,10 +146,9 @@ bool PrintBackendCUPS::EnumeratePrinters(PrinterList* printer_list) {
cups_dest_t* destinations = NULL;
int num_dests = GetDests(&destinations);
if ((num_dests == 0) && (cupsLastError() > IPP_OK_EVENTS_COMPLETE)) {
- VLOG(1) << "CP_CUPS: Error getting printers from CUPS server. Server: "
- << print_server_url_
- << " Error: "
- << static_cast<int>(cupsLastError());
+ VLOG(1) << "CUPS: Error getting printers from CUPS server"
+ << ", server: " << print_server_url_
+ << ", error: " << static_cast<int>(cupsLastError());
return false;
}
@@ -197,7 +196,9 @@ bool PrintBackendCUPS::EnumeratePrinters(PrinterList* printer_list) {
cupsFreeDests(num_dests, destinations);
- VLOG(1) << "CUPS: Enumerated " << printer_list->size() << " printers.";
+ VLOG(1) << "CUPS: Enumerated printers"
+ << ", server: " << print_server_url_
+ << ", # of printers: " << printer_list->size();
return true;
}
@@ -214,12 +215,13 @@ bool PrintBackendCUPS::GetPrinterCapsAndDefaults(
PrinterCapsAndDefaults* printer_info) {
DCHECK(printer_info);
- VLOG(1) << "CUPS: Getting Caps and Defaults for: " << printer_name;
+ VLOG(1) << "CUPS: Getting caps and defaults"
+ << ", printer name: " << printer_name;
FilePath ppd_path(GetPPD(printer_name.c_str()));
// In some cases CUPS failed to get ppd file.
if (ppd_path.empty()) {
- LOG(ERROR) << "CUPS: Failed to get PPD for: " << printer_name;
+ LOG(ERROR) << "CUPS: Failed to get PPD, printer name: " << printer_name;
return false;
}

Powered by Google App Engine
This is Rietveld 408576698