Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: chrome/service/cloud_print/cloud_print_connector.cc

Issue 10808086: Standardize log message style for cloudprint service and display printer id (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/cloud_print_connector.cc
diff --git a/chrome/service/cloud_print/cloud_print_connector.cc b/chrome/service/cloud_print/cloud_print_connector.cc
index 861d0c6ba60dafc2f4cf3be678a1e82aabd9ab9b..3629190d1490d0ac6131f4d411f6142625c2e6b1 100644
--- a/chrome/service/cloud_print/cloud_print_connector.cc
+++ b/chrome/service/cloud_print/cloud_print_connector.cc
@@ -36,7 +36,8 @@ CloudPrintConnector::CloudPrintConnector(
bool CloudPrintConnector::Start() {
DCHECK(!print_system_.get());
- VLOG(1) << "CP_CONNECTOR: Starting connector, id: " << proxy_id_;
+ VLOG(1) << "CP_CONNECTOR: Starting connector"
+ << ", proxy id: " << proxy_id_;
pending_tasks_.clear();
@@ -64,7 +65,8 @@ bool CloudPrintConnector::Start() {
}
void CloudPrintConnector::Stop() {
- VLOG(1) << "CP_CONNECTOR: Stopping connector, id: " << proxy_id_;
+ VLOG(1) << "CP_CONNECTOR: Stopping connector"
+ << ", proxy id: " << proxy_id_;
DCHECK(print_system_.get());
if (print_system_.get()) {
// Do uninitialization here.
@@ -236,8 +238,9 @@ CloudPrintConnector::HandlePrinterDeleteResponse(
const GURL& url,
DictionaryValue* json_data,
bool succeeded) {
- VLOG(1) << "CP_CONNECTOR: Handler printer delete response, succeeded:"
- << succeeded << " url: " << url;
+ VLOG(1) << "CP_CONNECTOR: Handler printer delete response"
+ << ", succeeded: " << succeeded
+ << ", url: " << url;
ContinuePendingTaskProcessing(); // Continue processing background tasks.
return CloudPrintURLFetcher::STOP_PROCESSING;
}
@@ -248,8 +251,9 @@ CloudPrintConnector::HandleRegisterPrinterResponse(
const GURL& url,
DictionaryValue* json_data,
bool succeeded) {
- VLOG(1) << "CP_CONNECTOR: Handler printer register response, succeeded:"
- << succeeded << " url: " << url;
+ VLOG(1) << "CP_CONNECTOR: Handler printer register response"
+ << ", succeeded: " << succeeded
+ << ", url: " << url;
if (succeeded) {
ListValue* printer_list = NULL;
// There should be a "printers" value in the JSON
@@ -322,8 +326,8 @@ void CloudPrintConnector::InitJobHandlerForPrinter(
PrinterJobHandler::PrinterInfoFromCloud printer_info_cloud;
printer_data->GetString(kIdValue, &printer_info_cloud.printer_id);
DCHECK(!printer_info_cloud.printer_id.empty());
- VLOG(1) << "CP_CONNECTOR: Init job handler for printer id: "
- << printer_info_cloud.printer_id;
+ VLOG(1) << "CP_CONNECTOR: Init job handler"
+ << ", printer id: " << printer_info_cloud.printer_id;
JobHandlerMap::iterator index = job_handler_map_.find(
printer_info_cloud.printer_id);
if (index != job_handler_map_.end())
@@ -552,4 +556,3 @@ bool CloudPrintConnector::IsSamePrinter(const std::string& name1,
const std::string& name2) const {
return (0 == base::strcasecmp(name1.c_str(), name2.c_str()));
}
Albert Bodenhamer 2012/07/23 20:49:02 Did you change something at EOF? If so, please un
Alex Yu 2012/07/23 21:16:51 I think my vim automatically deletes blank EOF. F
-
« no previous file with comments | « no previous file | chrome/service/cloud_print/print_system_cups.cc » ('j') | chrome/service/cloud_print/printer_job_handler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698