Fix memory leaks in RenderTextMac.

Fix memory leaks in RenderTextMac.

This addresses a TODO from http://crrev.com/147862 to
not leak CFAttributedString attributes and additionally
ensures that the CTFontRef is properly disposed.

Also renames SkColorToCGColorRef() to CGColorCreateFromSkColor()
to be clear that it follows the Create rule.

BUG=125664
TEST=No leaks on waterfall.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147948

[Nico, 2012-07-23 19:23:32]

LGTM

Thanks!

http://codereview.chromium.org/10808084/diff/1/ui/gfx/render_text_mac.cc
File ui/gfx/render_text_mac.cc (right):

http://codereview.chromium.org/10808084/diff/1/ui/gfx/render_text_mac.cc#newc...
ui/gfx/render_text_mac.cc:186: attributes_.reset(CFArrayCreateMutable(NULL, 0,
&kCFTypeArrayCallBacks));
nit: If you did this in ApplyStyles(), you could pass in a good guess for the
capacity

[Alexei Svitkine (slow), 2012-07-23 19:35:55]

http://codereview.chromium.org/10808084/diff/1/ui/gfx/render_text_mac.cc
File ui/gfx/render_text_mac.cc (right):

http://codereview.chromium.org/10808084/diff/1/ui/gfx/render_text_mac.cc#newc...
ui/gfx/render_text_mac.cc:186: attributes_.reset(CFArrayCreateMutable(NULL, 0,
&kCFTypeArrayCallBacks));
On 2012/07/23 19:23:32, Nico wrote:
> nit: If you did this in ApplyStyles(), you could pass in a good guess for the
> capacity

Good call, done!

[commit-bot: I haz the power, 2012-07-23 19:36:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10808084/5002

[commit-bot: I haz the power, 2012-07-23 19:50:14]

Try job failure for 10808084-5002 (retry) on win_rel for step "runhooks".
It's a second try, previously, step "runhooks" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-07-23 19:52:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10808084/5002

[commit-bot: I haz the power, 2012-07-23 21:17:31]

Change committed as 147948