Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: ui/views/bubble/bubble_delegate.cc

Issue 10808066: Fix position of web notification bubble and arrow (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: . Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/bubble/bubble_delegate.cc
diff --git a/ui/views/bubble/bubble_delegate.cc b/ui/views/bubble/bubble_delegate.cc
index 446b7b2de96529417a23c4e1c73570ba8ed29443..75dc5a55b7e40a18ba728dc8779ef571e42d191d 100644
--- a/ui/views/bubble/bubble_delegate.cc
+++ b/ui/views/bubble/bubble_delegate.cc
@@ -181,7 +181,17 @@ View* BubbleDelegateView::GetContentsView() {
NonClientFrameView* BubbleDelegateView::CreateNonClientFrameView(
Widget* widget) {
- return new BubbleFrameView(arrow_location(), color(), margins());
+ BubbleBorder::ArrowLocation arrow_loc = arrow_location();
+ if (base::i18n::IsRTL())
+ arrow_loc = BubbleBorder::horizontal_mirror(arrow_loc);
+ // TODO(alicet): Expose the shadow option in BorderContentsView when we make
+ // the fullscreen exit bubble use the new bubble code.
+ BubbleBorder* bubble_border =
msw 2012/07/27 20:32:04 nit: rename border to fit on one line.
stevenjb 2012/07/30 20:09:03 Done.
+ new BubbleBorder(arrow_loc, BubbleBorder::NO_SHADOW);
+ bubble_border->set_background_color(color());
+ BubbleFrameView* frame_view = new BubbleFrameView(margins(), bubble_border);
+ frame_view->set_background(new BubbleBackground(bubble_border));
+ return frame_view;
}
void BubbleDelegateView::OnWidgetClosing(Widget* widget) {

Powered by Google App Engine
This is Rietveld 408576698