Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: ui/views/bubble/bubble_frame_view.cc

Issue 10808066: Fix position of web notification bubble and arrow (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/bubble/bubble_frame_view.h ('k') | ui/views/bubble/bubble_frame_view_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_frame_view.cc
diff --git a/ui/views/bubble/bubble_frame_view.cc b/ui/views/bubble/bubble_frame_view.cc
index 3698a8d92d6e0007f890f66ddad8d04f3278f379..509ba6daa87b24c3c756ccf542025e004a60a978 100644
--- a/ui/views/bubble/bubble_frame_view.cc
+++ b/ui/views/bubble/bubble_frame_view.cc
@@ -39,18 +39,11 @@ int GetOffScreenLength(const gfx::Rect& monitor_bounds,
namespace views {
-BubbleFrameView::BubbleFrameView(BubbleBorder::ArrowLocation arrow_location,
- SkColor color,
- const gfx::Insets& margins)
- : bubble_border_(NULL),
+BubbleFrameView::BubbleFrameView(const gfx::Insets& margins,
+ BubbleBorder* border)
+ : bubble_border_(border),
content_margins_(margins) {
- if (base::i18n::IsRTL())
- arrow_location = BubbleBorder::horizontal_mirror(arrow_location);
- // TODO(alicet): Expose the shadow option in BorderContentsView when we make
- // the fullscreen exit bubble use the new bubble code.
- SetBubbleBorder(new BubbleBorder(arrow_location, BubbleBorder::NO_SHADOW));
- set_background(new BubbleBackground(bubble_border_));
- bubble_border()->set_background_color(color);
+ set_border(bubble_border_);
}
BubbleFrameView::~BubbleFrameView() {}
« no previous file with comments | « ui/views/bubble/bubble_frame_view.h ('k') | ui/views/bubble/bubble_frame_view_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698