media/filters/gpu_video_decoder.cc - Issue 10808058: Add support for VP8 decode to OmxVideoDecodeAccelerator, for HW that supports it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/gpu_video_decoder.cc

Issue 10808058: Add support for VP8 decode to OmxVideoDecodeAccelerator, for HW that supports it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/gpu_video_decoder.cc

diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc

index cbbfc9e943c275ae40d11b068697882a1e106a10..46069bc35e32c11261b9fdc49c8b5a65e37a2e91 100644

--- a/media/filters/gpu_video_decoder.cc

+++ b/media/filters/gpu_video_decoder.cc

@@ -151,7 +151,8 @@ void GpuVideoDecoder::Initialize(const scoped_refptr<DemuxerStream>& stream,

demuxer_stream_ = stream;

statistics_cb_ = statistics_cb;

- demuxer_stream_->EnableBitstreamConverter();

+ if (config.codec() == kCodecH264)

+ demuxer_stream_->EnableBitstreamConverter();

scherkus (not reviewing) 2012/07/20 20:20:20 q: do you recall the reason for having the bitstre

Ami GONE FROM CHROMIUM 2012/07/20 20:25:20 The decision long predates my involvement with the

natural_size_ = config.natural_size();

config_frame_duration_ = GetFrameDuration(config);

« media/ffmpeg/ffmpeg_common.cc ('K') | « media/ffmpeg/ffmpeg_common.cc ('k') | ppapi/api/dev/pp_video_dev.idl » ('j') | ppapi/api/dev/pp_video_dev.idl » ('J')