chrome/browser/download/download_service.cc - Issue 10808054: Don't leak ChromeDownloadManagerDelegate in DownloadService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_service.cc

Issue 10808054: Don't leak ChromeDownloadManagerDelegate in DownloadService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Actual fix Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_service.cc

diff --git a/chrome/browser/download/download_service.cc b/chrome/browser/download/download_service.cc

index a9d401756ef0c1a6a6b3feb14428ca55e4b6f7da..111c4bcefccc929643d237b5f44cd2f1d69509fe 100644

--- a/chrome/browser/download/download_service.cc

+++ b/chrome/browser/download/download_service.cc

@@ -107,5 +107,5 @@ void DownloadService::Shutdown() {

// manually earlier. See http://crbug.com/131692

BrowserContext::GetDownloadManager(profile_)->Shutdown();

}

- manager_delegate_.release();

+ manager_delegate_ = NULL;

Randy Smith (Not in Mondays) 2012/07/23 18:33:33 Whoops; nice catch.

}

« no previous file with comments | « no previous file | tools/valgrind/memcheck/suppressions.txt » ('j') | no next file with comments »