Don't leak ChromeDownloadManagerDelegate in DownloadService

Don't leak ChromeDownloadManagerDelegate in DownloadService

BUG=102255, 120893
TEST=memory bots


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148155

[asanka, 2012-07-23 15:52:52]

FYI. But the try runs were less than convincing.

[Randy Smith (Not in Mondays), 2012-07-23 18:33:32]

LGTM.  What do you mean by the try bot runs not being encouraging?  That this
doesn't fix the leaks?

http://codereview.chromium.org/10808054/diff/5002/chrome/browser/download/dow...
File chrome/browser/download/download_service.cc (right):

http://codereview.chromium.org/10808054/diff/5002/chrome/browser/download/dow...
chrome/browser/download/download_service.cc:110: manager_delegate_ = NULL;
Whoops; nice catch.

[asanka, 2012-07-23 18:49:57]

On 2012/07/23 18:33:32, rdsmith wrote:
> LGTM.  What do you mean by the try bot runs not being encouraging?  That this
> doesn't fix the leaks?

Thanks! The comment was about patchset 1 which only included the removal of
suppressions and didn't have the fix. The try run should have failed there, but
didn't.

http://codereview.chromium.org/10808054/diff/5002/chrome/browser/download/dow...
> File chrome/browser/download/download_service.cc (right):
> 
>
http://codereview.chromium.org/10808054/diff/5002/chrome/browser/download/dow...
> chrome/browser/download/download_service.cc:110: manager_delegate_ = NULL;
> Whoops; nice catch.

[commit-bot: I haz the power, 2012-07-24 16:27:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/10808054/10004

[commit-bot: I haz the power, 2012-07-24 19:02:54]

Change committed as 148155