Tidy up Android's is-tablet functionality.

Tidy up Android's is-tablet functionality.

Remove the code in sync/ that checks if the device is a tablet
and perform the check in the chrome/ layer based upon a
command line switch.

Additionally, rather than looking for a tablet when (not) setting
the Mobile specific user agent, look for --use-mobile-user-agent. The
embedder should set these command line switches as appropriate, so
remove the code that used to set them in the generic process startup.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148091

[benm (inactive), 2012-07-20 15:52:10]

ptal!

[Yaron, 2012-07-20 16:50:48]

lgtm

[sky, 2012-07-20 16:58:09]

https://chromiumcodereview.appspot.com/10808052/diff/1/chrome/browser/sync/gl...
File chrome/browser/sync/glue/session_model_associator.cc (right):

https://chromiumcodereview.appspot.com/10808052/diff/1/chrome/browser/sync/gl...
chrome/browser/sync/glue/session_model_associator.cc:72: bool IsTabletUi() {
I've never seen Ui capitalized like this -> UI

[benm (inactive), 2012-07-23 09:17:04]

https://chromiumcodereview.appspot.com/10808052/diff/1/chrome/browser/sync/gl...
File chrome/browser/sync/glue/session_model_associator.cc (right):

https://chromiumcodereview.appspot.com/10808052/diff/1/chrome/browser/sync/gl...
chrome/browser/sync/glue/session_model_associator.cc:72: bool IsTabletUi() {
On 2012/07/20 16:58:09, sky wrote:
> I've never seen Ui capitalized like this -> UI

Done.

[jochen (gone - plz use gerrit), 2012-07-23 15:08:19]

http://codereview.chromium.org/10808052/diff/5003/content/public/common/conte...
File content/public/common/content_switches.h (right):

http://codereview.chromium.org/10808052/diff/5003/content/public/common/conte...
content/public/common/content_switches.h:202: extern const char
kUseMobileUserAgent[];
why is this switch defined in content/ while tablet-ui is defined in chrome/?

Both are referenced by the .java file in content/ so shouldn't they both live in
content/?

[benm (inactive), 2012-07-23 15:20:41]

http://codereview.chromium.org/10808052/diff/5003/content/public/common/conte...
File content/public/common/content_switches.h (right):

http://codereview.chromium.org/10808052/diff/5003/content/public/common/conte...
content/public/common/content_switches.h:202: extern const char
kUseMobileUserAgent[];
Oh, good spot. My intent was to keep tablet-ness out of content/ and in the
chrome/ layer only, so it's misplaced in the Java file. I'll move it and send a
new CL.

[benm (inactive), 2012-07-23 15:58:42]

Note that the new place where the java TABLET_UI switch is defined is not
upstream so not part of this CL.

[sky, 2012-07-23 16:22:46]

LGTM

[benm (inactive), 2012-07-23 16:24:58]

+akalin for sync changes.

[jam, 2012-07-23 22:54:16]

lgtm

[akalin, 2012-07-24 04:38:37]

lgtm

[commit-bot: I haz the power, 2012-07-24 09:06:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benm@chromium.org/10808052/4004

[commit-bot: I haz the power, 2012-07-24 10:18:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benm@chromium.org/10808052/3005

[commit-bot: I haz the power, 2012-07-24 11:45:51]

Change committed as 148091

[gone, 2012-07-25 18:56:09]

Please fix this and land it when you can.

https://chromiumcodereview.appspot.com/10808052/diff/3005/chrome/common/chrom...
File chrome/common/chrome_content_client.cc (right):

https://chromiumcodereview.appspot.com/10808052/diff/3005/chrome/common/chrom...
chrome/common/chrome_content_client.cc:441: if
(!command_line->HasSwitch(switches::kUseMobileUserAgent)) {
The conditional is flipped here.

[benm (inactive), 2012-07-26 09:43:36]

http://codereview.chromium.org/10808052/diff/3005/chrome/common/chrome_conten...
File chrome/common/chrome_content_client.cc (right):

http://codereview.chromium.org/10808052/diff/3005/chrome/common/chrome_conten...
chrome/common/chrome_content_client.cc:441: if
(!command_line->HasSwitch(switches::kUseMobileUserAgent)) {
ah shoot! Thanks for spotting, sorry for merge pain :(

[benm (inactive), 2012-07-26 10:47:26]

http://codereview.chromium.org/10823035/ has the fix.