chrome/browser/chromeos/gdata/gdata_operations.h - Issue 10808027: gdrive: Get JSON feeds parsing off the UI thread.

Unified Diff: chrome/browser/chromeos/gdata/gdata_operations.h

Issue 10808027: gdrive: Get JSON feeds parsing off the UI thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase and Fix conflict and build error. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/gdata/gdata_documents_service_browsertest.cc ('k') | chrome/browser/chromeos/gdata/gdata_operations.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/gdata/gdata_operations.h

diff --git a/chrome/browser/chromeos/gdata/gdata_operations.h b/chrome/browser/chromeos/gdata/gdata_operations.h

index 8c1f096493faef542c18021f42b1ffb830a6d416..dc4091ad46a4f7b70006e1d7f0e5d259c67b7910 100644

--- a/chrome/browser/chromeos/gdata/gdata_operations.h

+++ b/chrome/browser/chromeos/gdata/gdata_operations.h

@@ -100,7 +100,7 @@ class DownloadFileOperation : public UrlFetchOperationBase {

protected:

// Overridden from UrlFetchOperationBase.

virtual GURL GetURL() const OVERRIDE;

- virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

+ virtual void ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) OVERRIDE;

// Overridden from net::URLFetcherDelegate.

@@ -249,11 +249,12 @@ class AuthorizeAppsOperation : public GetDataOperation {

// Overridden from GetDataOperation.

virtual GURL GetURL() const OVERRIDE;

- virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

+ virtual void ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

// Must override GetDataOperation's ParseResponse because the response is XML

// not JSON.

- virtual base::Value* ParseResponse(const std::string& data) OVERRIDE;

+ virtual void ParseResponse(GDataErrorCode fetch_error_code,

+ const std::string& data) OVERRIDE;

private:

std::string app_id_;

GURL document_url_;

@@ -328,7 +329,7 @@ class InitiateUploadOperation : public UrlFetchOperationBase {

protected:

// Overridden from UrlFetchOperationBase.

virtual GURL GetURL() const OVERRIDE;

- virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

+ virtual void ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

virtual void NotifySuccessToOperationRegistry() OVERRIDE;

virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) OVERRIDE;

@@ -360,7 +361,7 @@ class ResumeUploadOperation : public UrlFetchOperationBase {

protected:

// Overridden from UrlFetchOperationBase.

virtual GURL GetURL() const OVERRIDE;

- virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

+ virtual void ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

virtual void NotifyStartToOperationRegistry() OVERRIDE;

virtual void NotifySuccessToOperationRegistry() OVERRIDE;

virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) OVERRIDE;

@@ -427,7 +428,7 @@ class GetContactPhotoOperation : public UrlFetchOperationBase {

protected:

// Overridden from UrlFetchOperationBase.

virtual GURL GetURL() const OVERRIDE;

- virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

+ virtual void ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;

virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) OVERRIDE;

private: