Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: chrome/browser/chromeos/gdata/gdata_operations.h

Issue 10808027: gdrive: Get JSON feeds parsing off the UI thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix reviews and rebase Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_operations.h
diff --git a/chrome/browser/chromeos/gdata/gdata_operations.h b/chrome/browser/chromeos/gdata/gdata_operations.h
index e0e78042858476b5f6f8c63437333291bcf1b062..cee3616e60a56ad3b27ada76454ce93ea463fc63 100644
--- a/chrome/browser/chromeos/gdata/gdata_operations.h
+++ b/chrome/browser/chromeos/gdata/gdata_operations.h
@@ -100,7 +100,9 @@ class DownloadFileOperation : public UrlFetchOperationBase {
protected:
// Overridden from UrlFetchOperationBase.
virtual GURL GetURL() const OVERRIDE;
- virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;
+ virtual void ProcessURLFetchResults(
+ const net::URLFetcher* source,
+ const ProcessURLFetchResultsCallback& result_callback) OVERRIDE;
virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) OVERRIDE;
// Overridden from net::URLFetcherDelegate.
@@ -249,11 +251,16 @@ class AuthorizeAppsOperation : public GetDataOperation {
// Overridden from GetDataOperation.
virtual GURL GetURL() const OVERRIDE;
- virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;
+ virtual void ProcessURLFetchResults(
+ const net::URLFetcher* source,
+ const ProcessURLFetchResultsCallback& result_callback) OVERRIDE;
// Must override GetDataOperation's ParseResponse because the response is XML
// not JSON.
- virtual base::Value* ParseResponse(const std::string& data) OVERRIDE;
+ virtual void ParseResponse(
+ GDataErrorCode fetch_error_code,
+ const std::string& data,
+ const ProcessURLFetchResultsCallback& result_callback) OVERRIDE;
private:
std::string app_id_;
GURL document_url_;
@@ -328,7 +335,9 @@ class InitiateUploadOperation : public UrlFetchOperationBase {
protected:
// Overridden from UrlFetchOperationBase.
virtual GURL GetURL() const OVERRIDE;
- virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;
+ virtual void ProcessURLFetchResults(
+ const net::URLFetcher* source,
+ const ProcessURLFetchResultsCallback& result_callback) OVERRIDE;
virtual void NotifySuccessToOperationRegistry() OVERRIDE;
virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) OVERRIDE;
@@ -360,7 +369,10 @@ class ResumeUploadOperation : public UrlFetchOperationBase {
protected:
// Overridden from UrlFetchOperationBase.
virtual GURL GetURL() const OVERRIDE;
- virtual bool ProcessURLFetchResults(const net::URLFetcher* source) OVERRIDE;
+ virtual void ProcessURLFetchResults(
+ const net::URLFetcher* source,
+ const ProcessURLFetchResultsCallback& result_callback) OVERRIDE;
+
hashimoto 2012/07/25 06:14:21 nit: Remove blank line.
yoshiki 2012/07/25 17:24:27 Done.
virtual void NotifyStartToOperationRegistry() OVERRIDE;
virtual void NotifySuccessToOperationRegistry() OVERRIDE;
virtual void RunCallbackOnPrematureFailure(GDataErrorCode code) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698