Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Unified Diff: build/common.gypi

Issue 10807019: Hook up use_system_libjpeg for Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed comment Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/envsetup.sh ('k') | third_party/libjpeg/libjpeg.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index cd2e4bf1a35cbbfd49ea4f957dd56e4b492278a8..587506269d941382639103a4752293fc7ce8033f 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -512,6 +512,12 @@
['OS!="mac" and OS!="android"', {
'use_canvas_skia%': 1,
}],
+
+ ['OS=="android"', {
+ # When building as part of the Android system, use system libraries
+ # where possible to reduce ROM size.
+ 'use_system_libjpeg%': '<(android_build_type)',
+ }],
],
},
@@ -592,6 +598,7 @@
'sas_dll_path%': '<(sas_dll_path)',
'wix_path%': '<(wix_path)',
'android_upstream_bringup%': '<(android_upstream_bringup)',
+ 'use_system_libjpeg%': '<(use_system_libjpeg)',
# Use system yasm instead of bundled one.
'use_system_yasm%': 0,
@@ -892,8 +899,9 @@
}],
],
- # Switch between different build types, currently only '0' is
- # supported.
+ # Sets whether we're building with the Android SDK/NDK (and hence
+ # with Ant, value 0), or as part of the Android system (and hence
+ # with the Android build system, value 1).
'android_build_type%': 0,
},
'android_ndk_root%': '<(android_ndk_root)',
@@ -975,19 +983,14 @@
}],
],
- # TODO(steveblock): Investigate using the system versions of sqlite and
- # libjpeg.
- # Enable to use system sqlite.
+ # When building as part of the Android system, use system libraries
+ # where possible to reduce ROM size.
+ # TODO(steveblock): Investigate using the system version of sqlite.
'use_system_sqlite%': 0, # '<(android_build_type)',
- # Enable to use system libjpeg.
- 'use_system_libjpeg%': 0, # '<(android_build_type)',
- # Enable to use the system expat.
'use_system_expat%': '<(android_build_type)',
- # Enable to use the system ICU.
'use_system_icu%': '<(android_build_type)',
- # Enable to use the system stlport, otherwise statically
- # link the NDK one?
'use_system_stlport%': '<(android_build_type)',
+
# Copy it out one scope.
'android_build_type%': '<(android_build_type)',
}], # OS=="android"
« no previous file with comments | « build/android/envsetup.sh ('k') | third_party/libjpeg/libjpeg.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698