Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/browser/ui/views/browser_action_view.h

Issue 10806058: Move icon fallbacks into ExtensionAction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move the icon cache inside ExtensionAction. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/browser_action_view.h
diff --git a/chrome/browser/ui/views/browser_action_view.h b/chrome/browser/ui/views/browser_action_view.h
index a2ab30fe347f7bd16e5fa622ddff6e94b21115a3..316ab876c47e8780502cf441b7d24faadd88c905 100644
--- a/chrome/browser/ui/views/browser_action_view.h
+++ b/chrome/browser/ui/views/browser_action_view.h
@@ -45,9 +45,6 @@ class BrowserActionButton : public views::MenuButton,
// Called to update the display to match the browser action's state.
void UpdateState();
- // Returns the default icon, if any.
- const SkBitmap& default_icon() const { return default_icon_; }
-
// Does this button's action have a popup?
virtual bool IsPopup();
virtual GURL GetPopupUrl();
@@ -125,10 +122,6 @@ class BrowserActionButton : public views::MenuButton,
// asynchronously.
ImageLoadingTracker tracker_;
- // The default icon for our browser action. This might be non-empty if the
- // browser action had a value for default_icon in the manifest.
- SkBitmap default_icon_;
-
// The browser action shelf.
BrowserActionsContainer* panel_;

Powered by Google App Engine
This is Rietveld 408576698