Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

Issue 10806058: Move icon fallbacks into ExtensionAction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move the icon cache inside ExtensionAction. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
diff --git a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
index 13e46a88551df5f6dcc242d98f16a26936204608..737b94c248cf4ec7c8a9a8c3f8a1f55ce760b212 100644
--- a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
+++ b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
@@ -104,7 +104,8 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, DynamicBrowserAction) {
// Set prev_id which holds the id of the previous image, and use it in the
// next test to see if the image changes.
- uint32_t prev_id = extension->browser_action()->GetIcon(0).getGenerationID();
+ uint32_t prev_id = extension->browser_action()->GetIcon(0).
+ ToSkBitmap()->getGenerationID();
// Tell the extension to update the icon using setIcon({imageData:...}).
ResultCatcher catcher;
@@ -114,15 +115,20 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, DynamicBrowserAction) {
// Test that we received the changes.
EXPECT_TRUE(GetBrowserActionsBar().HasIcon(0));
- EXPECT_NE(prev_id, extension->browser_action()->GetIcon(0).getGenerationID());
- prev_id = extension->browser_action()->GetIcon(0).getGenerationID();
+ EXPECT_NE(prev_id,
+ extension->browser_action()->GetIcon(0).
+ ToSkBitmap()->getGenerationID());
+ prev_id = extension->browser_action()->GetIcon(0).
+ ToSkBitmap()->getGenerationID();
// Tell the extension to update the icon using setIcon({path:...}).
ui_test_utils::NavigateToURL(browser(),
GURL(extension->GetResourceURL("update2.html")));
ASSERT_TRUE(catcher.GetNextResult());
EXPECT_TRUE(GetBrowserActionsBar().HasIcon(0));
- EXPECT_NE(prev_id, extension->browser_action()->GetIcon(0).getGenerationID());
+ EXPECT_NE(prev_id,
+ extension->browser_action()->GetIcon(0).
+ ToSkBitmap()->getGenerationID());
}
// This test is flaky as per http://crbug.com/74557.

Powered by Google App Engine
This is Rietveld 408576698