tools/checkdeps/checkdeps.py - Issue 10806049: Add checkdeps presubmit check. Warns on new #includes of dependencies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/checkdeps/checkdeps.py

Issue 10806049: Add checkdeps presubmit check. Warns on new #includes of dependencies (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge to parent. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/checkdeps/checkdeps.py

diff --git a/tools/checkdeps/checkdeps.py b/tools/checkdeps/checkdeps.py

index 7661d9d04b398dd7f4c0e23e9a745c783007517d..0b2b7ac6a642bb15c49253836f6d8674747fe3fb 100755

--- a/tools/checkdeps/checkdeps.py

+++ b/tools/checkdeps/checkdeps.py

@@ -340,7 +340,7 @@ class DepsChecker(object):

problems = []

for file_path, include_lines in added_includes:

# TODO(joi): Make this cover Java as well.

- if not os.path.splitext(file_path)[1] in cpp.EXTENSIONS:

+ if not cpp.IsCppFile(file_path):

pass

rules_for_file = GetDirectoryRules(os.path.dirname(file_path))

if rules_for_file:

« no previous file with comments | « PRESUBMIT.py ('k') | tools/checkdeps/cpp_checker.py » ('j') | no next file with comments »