Add checkdeps presubmit check. Warns on new #includes of dependencies

tools/checkdeps/checkdeps.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Makes sure that files include headers from allowed directories.
 
 Checks DEPS files in the source tree for rules, and applies those rules to
 "#include" commands in source files. Any source file including something not
 permitted by the DEPS files will fail.
@@ skipping 213 matching lines @@
       success = False
 
   # Next recurse into the subdirectories.
   for cur in dirs_to_check:
     if not CheckDirectory(rules, checkers, cur):
       success = False
 
   return success
 
 
+def ShouldCheckAddedIncludesInFile(file_path):

[M-A Ruel, 2012/07/26 14:03:28]

ShouldcheckIncludesInCppFile ?

Just to be clearer. Otherwise Java-people looking that the PRESUBMIT.py could be
confused about it.

This is taken for granted that java people are easily confused so this nit is
optional.

+  """Whether to check added includes in the given file."""
+  return os.path.splitext(file_path)[1] in cpp_checker.CppChecker.EXTENSIONS
+
+
 def CheckAddedIncludes(added_includes):

[M-A Ruel, 2012/07/26 14:03:28]

I'd like to have Cpp here too but this is outside the scope of this CL.

   """This is used from PRESUBMIT.py to check new #include statements added in
   the change being presubmit checked.
 
   Args:
     added_includes: ((file_path, (include_line, include_line, ...), ...)
 
   Return:
     A list of tuples, (bad_file_path, rule_type, rule_description)
     where rule_type is one of Rule.DISALLOW or Rule.TEMP_ALLOW and
     rule_description is human-readable. Empty if no problems.
@@ skipping 36 matching lines @@
         directory_rules[dir_path] = None
       else:
         ApplyDirectoryRulesAndSkipSubdirs(parent_rules, dir_path)
     return directory_rules[dir_path]
 
   cpp = cpp_checker.CppChecker(VERBOSE)
 
   problems = []
   for file_path, include_lines in added_includes:
     # TODO(joi): Make this cover Java as well.
-    if not os.path.splitext(file_path)[1] in cpp.EXTENSIONS:
+    if not ShouldCheckAddedIncludesInFile(file_path):
       pass
     rules_for_file = GetDirectoryRules(os.path.dirname(file_path))
     if rules_for_file:
       for line in include_lines:
         is_include, line_status, rule_type = cpp.CheckLine(
             rules_for_file, line, True)
         if rule_type != Rule.ALLOW:
           problems.append((file_path, rule_type, line_status))
   return problems
 
@@ skipping 101 matching lines @@
                            'to "../../.." relative to the script file, which '
                            'will normally be the repository root.')
   option_parser.add_option("-v", "--verbose", action="store_true",
                            default=False, help="Print debug logging")
   options, args = option_parser.parse_args()
   return checkdeps(options, args)
 
 
 if '__main__' == __name__:
   sys.exit(main())