chrome/browser/ui/chrome_pages.cc - Issue 10806048: Change the navigation code of sync promo slightly to navigate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/chrome_pages.cc

Issue 10806048: Change the navigation code of sync promo slightly to navigate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/chrome_pages.cc

===================================================================

--- chrome/browser/ui/chrome_pages.cc (revision 147566)

+++ chrome/browser/ui/chrome_pages.cc (working copy)

@@ -180,7 +180,7 @@

} else if (SyncPromoUI::ShouldShowSyncPromo(browser->profile()) &&

login_service->current_login_ui() == NULL) {

// There is no currently active login UI, so display a new promo page.

- GURL url(SyncPromoUI::GetSyncPromoURL(GURL(), source));

+ GURL url(SyncPromoUI::GetSyncPromoURL(GURL(), source, false));

NavigateParams params(GetSingletonTabNavigateParams(browser, GURL(url)));

params.path_behavior = NavigateParams::IGNORE_AND_NAVIGATE;

ShowSingletonTabOverwritingNTP(browser, params);

« no previous file with comments | « no previous file | chrome/browser/ui/startup/startup_browser_creator_impl.cc » ('j') | no next file with comments »