Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc

Issue 10805094: Mark down in web intents picker controller when it is part of a TabContents that is hosting a web i… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change assert Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc b/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc
index 48053abace483474f2a352224c603d8fe3102fdf..22c5b0ac716e046bdcfb08ed72847cf7527fd6c2 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc
+++ b/chrome/browser/ui/intents/web_intent_picker_controller_browsertest.cc
@@ -222,6 +222,11 @@ class WebIntentPickerControllerBrowserTest : public InProcessBrowserTest {
host_resolver()->AddRule("www.example.com", "127.0.0.1");
}
+ content::WebContents* GetWindowDispositionTarget(
+ WebIntentPickerController* controller) {
+ return controller->window_disposition_source_;
+ }
+
virtual void SetUpOnMainThread() OVERRIDE {
// The FakeURLFetcherFactory will return a NULL URLFetcher if a request is
// created for a URL it doesn't know and there is no default factory.
@@ -352,6 +357,9 @@ IN_PROC_BROWSER_TEST_F(WebIntentPickerControllerBrowserTest, ChooseService) {
EXPECT_EQ(GURL(kServiceURL2),
chrome::GetActiveWebContents(browser())->GetURL());
+ EXPECT_TRUE(NULL != GetWindowDispositionTarget(
groby-ooo-7-16 2012/07/30 20:10:05 nit: Without the NULL!=?
Greg Billock 2012/07/30 20:23:57 Done.
+ chrome::GetActiveTabContents(browser())->web_intent_picker_controller()));
+
EXPECT_TRUE(dispatcher.dispatched_);
OnSendReturnMessage(webkit_glue::WEB_INTENT_REPLY_SUCCESS);

Powered by Google App Engine
This is Rietveld 408576698