Flip HW video decode from being behind an "enable" flag to being behind a "disable" flag

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 2349 matching lines @@
     // from the perspective of the audio renderer.
     audio_source_provider = new RenderAudioSourceProvider();
 
     // Add the chrome specific audio renderer, using audio_source_provider
     // as the sink.
     media::AudioRendererImpl* audio_renderer =
         new media::AudioRendererImpl(audio_source_provider);
     collection->AddAudioRenderer(audio_renderer);
   }
 
+  bool use_accelerated_video_decode;

[jam, 2012/07/23 22:51:31]

nit: it would be more concise to write this as 

bool use_accelerated_video_decode = false;
#if defined(OS_CHROMEOS) && defined(ARCH_CPU_ARMEL)
use_accelerated_video_decode = true;
#endif

[Ami GONE FROM CHROMIUM, 2012/07/23 22:55:51]

Yeah; my thought here was that this way would make it obvious where to flip the
switches as they become appropriate.  I'm fine going the other way, too.

+#if defined(OS_WIN)
+  use_accelerated_video_decode = false;
+#elif defined(OS_MACOSX)
+  use_accelerated_video_decode = false;
+#elif defined(OS_CHROMEOS) && defined(ARCH_CPU_X86_FAMILY)
+  use_accelerated_video_decode = false;
+#elif defined(OS_CHROMEOS) && defined(ARCH_CPU_ARMEL)
+  use_accelerated_video_decode = true;
+#endif
+  use_accelerated_video_decode &= !CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kDisableAcceleratedVideoDecode);
   base::WeakPtr<WebGraphicsContext3DCommandBufferImpl> context3d =
-      !CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kEnableAcceleratedVideoDecode) ?
-      base::WeakPtr<WebGraphicsContext3DCommandBufferImpl>() :
-      RenderThreadImpl::current()->GetGpuVDAContext3D();
+      use_accelerated_video_decode ?
+      RenderThreadImpl::current()->GetGpuVDAContext3D() :
+      base::WeakPtr<WebGraphicsContext3DCommandBufferImpl>();
   if (context3d) {
     MessageLoop* factories_loop =
         RenderThreadImpl::current()->compositor_thread() ?
         RenderThreadImpl::current()->compositor_thread()->GetWebThread()
             ->message_loop() :
         MessageLoop::current();
     GpuChannelHost* gpu_channel_host =
         RenderThreadImpl::current()->EstablishGpuChannelSync(
             content::CAUSE_FOR_GPU_LAUNCH_VIDEODECODEACCELERATOR_INITIALIZE);
     collection->AddVideoDecoder(new media::GpuVideoDecoder(
@@ skipping 3316 matching lines @@
 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const {
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit() {
   DCHECK(!java_bridge_dispatcher_);
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_ = new JavaBridgeDispatcher(this);
 #endif
 }