Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: tools/checkdeps/java_checker.py

Issue 10805042: Implement ability to specify temporarily-allowed dependencies in DEPS (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to LKGR. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/checkdeps/cpp_checker.py ('k') | tools/checkdeps/rules.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/checkdeps/java_checker.py
diff --git a/tools/checkdeps/java_checker.py b/tools/checkdeps/java_checker.py
index 933fd84d2d668c9681684f0500d2c445107e4875..cc6fe66815a4131307513d676e6bc807ca69884c 100644
--- a/tools/checkdeps/java_checker.py
+++ b/tools/checkdeps/java_checker.py
@@ -8,6 +8,8 @@ import codecs
import os
import re
+from rules import Rule
+
class JavaChecker(object):
"""Import checker for Java files.
@@ -94,7 +96,7 @@ class JavaChecker(object):
# Convert Windows paths to Unix style, as used in DEPS files.
include_path = include_path.replace(os.path.sep, '/')
(allowed, why_failed) = rules.DirAllowed(include_path)
- if not allowed:
+ if allowed == Rule.DISALLOW:
if self._verbose:
result += '\nFor %s' % rules
result += 'Illegal include: "%s"\n Because of %s\n' % (
« no previous file with comments | « tools/checkdeps/cpp_checker.py ('k') | tools/checkdeps/rules.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698