Implement ability to specify temporarily-allowed dependencies in DEPS

tools/checkdeps/checkdeps_manualtest.py

+#!/usr/bin/env python
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Tests for checkdeps that require manual evaluation.
+"""
+
+import checkdeps
+
+
+def TestCheckAddedIncludes():
+  # Note that these tests depend on the rules currently in DEPS files
+  # checked into the tree, which may change.  Therefore the test is
+  # only run manually and may need to be updated from time to time.

[M-A Ruel, 2012/07/26 13:50:51]

Optional: I think a data subdirectory should be created, with the content of the
following you wrote.

Then import checkdeps the same way you do in the presubmit and assert on the
return value.

Then the test becomes automatic. :)

[Jói, 2012/07/26 17:05:52]

Done, I was thinking about this and should have done it from the start to save
time manually testing each iteration.

+  problems = checkdeps.CheckAddedIncludes(
+    # The first of these should fail as a DISALLOW, the second should
+    # fail as a TEMP_ALLOW, because of rules in chrome/browser/DEPS.
+    [['chrome/browser/bingo.cc',
+      ['#include "chrome/browser/ui/views/boondog.h"',
+       '#include "chrome/browser/ui/views/ash/panel_view_aura.h"']],
+     # This should fail because of no rule applying.
+     ['chrome/browser/lifetime/bongo.cc', ['#include "fantastic/food.h"']],
+     # The following two shouldn't fail as they are under a directory
+     # that is skipped for checking, in src/DEPS.
+     ['breakpad/fooblat.cc', ['#include "fantastic/food.h"']],
+     ['breakpad/bingo/bongo/fooblat.cc', ['#include "fantastic/food.h"']],
+   ])
+
+  for problem in problems:
+    print problem[0]
+    print problem[1]
+    print problem[2]
+    print
+    print
+
+
+if __name__ == '__main__':
+  TestCheckAddedIncludes()
+

[M-A Ruel, 2012/07/26 13:50:51]

remo

[Jói, 2012/07/26 17:05:52]

Done.