Fix flakiness in RemoteFileSystemExtensionApiTests

chrome/browser/chromeos/extensions/external_filesystem_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop_proxy.h"
@@ skipping 175 matching lines @@
  private:
   FilePath test_mount_point_;
 };
 
 class RemoteFileSystemExtensionApiTest : public ExtensionApiTest {
  public:
   RemoteFileSystemExtensionApiTest() {}
 
   virtual ~RemoteFileSystemExtensionApiTest() {}
 
-  // Sets up GDataFileSystem that will be used in the test.
-  // NOTE: Remote mount point should get added to mount point provider when
-  // getLocalFileSystem is called from filebrowser_component extension.
-  virtual void SetupGDataFileSystemForTest() {
-    // |mock_documents_service_| is owned by |system_service|.
+  virtual void SetUp() OVERRIDE {
+    // Set up cache root and documents service to be used when creating gdata
+    // system service. This has to be done early on (before the browser is
+    // created) because the system service instance is initialized very early
+    // by FileBrowserEventRouter.
+    FilePath tmp_dir_path;
+    PathService::Get(base::DIR_TEMP, &tmp_dir_path);
+    ASSERT_TRUE(test_cache_root_.CreateUniqueTempDirUnderPath(tmp_dir_path));
+    gdata::GDataSystemServiceFactory::set_cache_root_for_test(
+        test_cache_root_.path().value());
+
     mock_documents_service_ = new gdata::MockDocumentsService();
+
     operation_registry_.reset(new gdata::GDataOperationRegistry());
-    gdata::GDataSystemService* system_service =
-        gdata::GDataSystemServiceFactory::GetInstance()->
-        GetWithCustomDocumentsServiceForTesting(
-            browser()->profile(), mock_documents_service_);
-    EXPECT_TRUE(system_service);
+    // FileBrowserEventRouter will add and remove itself from operation registry
+    // observer list.
+    EXPECT_CALL(*mock_documents_service_, operation_registry()).
+        WillRepeatedly(Return(operation_registry_.get()));
+
+    // |mock_documents_service_| will eventually get owned by a system service.
+    gdata::GDataSystemServiceFactory::set_documents_service_for_test(
+        mock_documents_service_);
+
+    ExtensionApiTest::SetUp();
+  }
+
+  virtual void TearDown() OVERRIDE {
+    // Let's make sure we don't leak documents service.
+    gdata::GDataSystemServiceFactory::set_documents_service_for_test(NULL);
+    gdata::GDataSystemServiceFactory::set_cache_root_for_test(std::string());
+    ExtensionApiTest::TearDown();
   }
 
  protected:
+  ScopedTempDir test_cache_root_;
   gdata::MockDocumentsService* mock_documents_service_;
   scoped_ptr<gdata::GDataOperationRegistry> operation_registry_;
 };
 
 IN_PROC_BROWSER_TEST_F(FileSystemExtensionApiTest, LocalFileSystem) {
   AddTmpMountPoint();
   ASSERT_TRUE(RunComponentExtensionTest("local_filesystem")) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(FileSystemExtensionApiTest, FileBrowserTest) {
@@ skipping 30 matching lines @@
                        FileBrowserTestWriteComponent) {
   AddTmpMountPoint();
   ASSERT_TRUE(RunComponentExtensionTest("filesystem_handler_write"))
       << message_;
   ASSERT_TRUE(RunExtensionSubtest(
       "filebrowser_component", "write.html", kComponentFlags)) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(RemoteFileSystemExtensionApiTest,
                        RemoteMountPoint) {
-  SetupGDataFileSystemForTest();
-
   EXPECT_CALL(*mock_documents_service_, GetAccountMetadata(_)).Times(1);
 
   // First, file browser will try to create new directory.
   scoped_ptr<base::Value> dir_value(LoadJSONFile(kTestDirectory));
   EXPECT_CALL(*mock_documents_service_,
               CreateDirectory(_, _, _))
       .WillOnce(MockCreateDirectoryCallback(gdata::HTTP_SUCCESS, &dir_value));
 
   // Then the test will try to read an existing file file.
   // Remote filesystem should first request root feed from gdata server.
@@ skipping 19 matching lines @@
 
   // We expect to download url defined in document entry returned by
   // GetDocumentEntry mock implementation.
   EXPECT_CALL(*mock_documents_service_,
               DownloadFile(_, _, GURL("https://file_content_url_changed"),
                            _, _))
       .WillOnce(MockDownloadFileCallback(gdata::HTTP_SUCCESS));
 
   // On exit, all operations in progress should be cancelled.
   EXPECT_CALL(*mock_documents_service_, CancelAll());
-  // This one is called on exit, but we don't care much about it, as long as it
-  // retunrs something valid (i.e. not NULL).
-  EXPECT_CALL(*mock_documents_service_, operation_registry()).
-      WillRepeatedly(Return(operation_registry_.get()));
 
   // All is set... RUN THE TEST.
   EXPECT_TRUE(RunExtensionTest("filesystem_handler")) << message_;
   EXPECT_TRUE(RunExtensionSubtest("filebrowser_component", "remote.html",
       kComponentFlags)) << message_;
 }
 
 // This test fails under AddressSanitizer, see http://crbug.com/136169.
 #if defined(ADDRESS_SANITIZER)
 #define MAYBE_ContentSearch DISABLED_ContentSearch
 #else
 #define MAYBE_ContentSearch ContentSearch
 #endif
 IN_PROC_BROWSER_TEST_F(RemoteFileSystemExtensionApiTest,
                        MAYBE_ContentSearch) {
-  SetupGDataFileSystemForTest();
-
   EXPECT_CALL(*mock_documents_service_, GetAccountMetadata(_)).Times(1);
 
   // First, test will get drive root directory, to init file system.
   scoped_ptr<base::Value> documents_value(LoadJSONFile(kTestRootFeed));
   EXPECT_CALL(*mock_documents_service_,
               GetDocuments(_, _, "", _, _))
       .WillOnce(MockGetDocumentsCallback(gdata::HTTP_SUCCESS,
                                          &documents_value));
 
   // We return the whole test file system in serch results.
@@ skipping 13 matching lines @@
 
   // We expect to download url defined in document entry returned by
   // GetDocumentEntry mock implementation.
   EXPECT_CALL(*mock_documents_service_,
               DownloadFile(_, _, GURL("https://file_content_url_changed"),
                            _, _))
       .WillOnce(MockDownloadFileCallback(gdata::HTTP_SUCCESS));
 
   // On exit, all operations in progress should be cancelled.
   EXPECT_CALL(*mock_documents_service_, CancelAll());
-  // This one is called on exit, but we don't care much about it, as long as it
-  // retunrs something valid (i.e. not NULL).
-  EXPECT_CALL(*mock_documents_service_, operation_registry()).
-      WillRepeatedly(Return(operation_registry_.get()));
 
   // All is set... RUN THE TEST.
   EXPECT_TRUE(RunExtensionSubtest("filebrowser_component", "remote_search.html",
       kComponentFlags)) << message_;
 }