Kill DownloadItem::IsOtr()

content/browser/download/download_manager_impl.cc

Index: content/browser/download/download_manager_impl.cc
diff --git a/content/browser/download/download_manager_impl.cc b/content/browser/download/download_manager_impl.cc
index c1e983e7d4e310ce3406ac075ecb612c23c9110e..239ccab7e1cde88b09cb905fc3787f53839a757e 100644
--- a/content/browser/download/download_manager_impl.cc
+++ b/content/browser/download/download_manager_impl.cc
@@ -177,21 +177,19 @@ class DownloadItemFactoryImpl : public content::DownloadItemFactory {
         DownloadItemImplDelegate* delegate,
         const DownloadCreateInfo& info,
         scoped_ptr<DownloadRequestHandleInterface> request_handle,
-        bool is_otr,
         const net::BoundNetLog& bound_net_log) OVERRIDE {
       return new DownloadItemImpl(delegate, info, request_handle.Pass(),
-                                  is_otr, bound_net_log);
+                                  bound_net_log);
     }
 
     virtual DownloadItemImpl* CreateSavePageItem(
         DownloadItemImplDelegate* delegate,
         const FilePath& path,
         const GURL& url,
-        bool is_otr,
         content::DownloadId download_id,
         const std::string& mime_type,
         const net::BoundNetLog& bound_net_log) OVERRIDE {
-      return new DownloadItemImpl(delegate, path, url, is_otr, download_id,
+      return new DownloadItemImpl(delegate, path, url, download_id,
                                   mime_type, bound_net_log);
     }
 };
@@ -377,13 +375,9 @@ void DownloadManagerImpl::SearchDownloads(const string16& query,
   for (DownloadMap::iterator it = downloads_.begin();
        it != downloads_.end(); ++it) {
     DownloadItemImpl* download_item = it->second;
-    // Display Incognito downloads only in Incognito window, and vice versa.
-    // The Incognito Downloads page will get the list of non-Incognito downloads
-    // from its parent profile.
     // TODO(benjhayden): Don't check IsPersisted().
     if (!download_item->IsTemporary() &&
         download_item->IsPersisted() &&
-        (browser_context_->IsOffTheRecord() == download_item->IsOtr()) &&
         download_item->MatchesQuery(query_lower)) {
       result->push_back(download_item);
     }
@@ -534,7 +528,7 @@ net::BoundNetLog DownloadManagerImpl::CreateDownloadItem(
       this, *info,
       scoped_ptr<DownloadRequestHandleInterface>(
           new DownloadRequestHandle(info->request_handle)).Pass(),
-      browser_context_->IsOffTheRecord(), bound_net_log);
+      bound_net_log);
 
   DCHECK(!ContainsKey(downloads_, download->GetId()));
   downloads_[download->GetId()] = download;
@@ -548,7 +542,6 @@ net::BoundNetLog DownloadManagerImpl::CreateDownloadItem(
 DownloadItemImpl* DownloadManagerImpl::CreateSavePackageDownloadItem(
     const FilePath& main_file_path,
     const GURL& page_url,
-    bool is_otr,
     const std::string& mime_type,
     DownloadItem::Observer* observer) {
   net::BoundNetLog bound_net_log =
@@ -557,7 +550,6 @@ DownloadItemImpl* DownloadManagerImpl::CreateSavePackageDownloadItem(
       this,
       main_file_path,
       page_url,
-      is_otr,
       GetNextId(),
       mime_type,
       bound_net_log);