Kill DownloadItem::IsOtr()

chrome/browser/automation/automation_provider_observers.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOMATION_AUTOMATION_PROVIDER_OBSERVERS_H_
 #define CHROME_BROWSER_AUTOMATION_AUTOMATION_PROVIDER_OBSERVERS_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 1074 matching lines @@
 };
 
 // Allows the automation provider to wait until the download has been updated
 // or opened.
 class AutomationProviderDownloadUpdatedObserver
     : public content::DownloadItem::Observer {
  public:
   AutomationProviderDownloadUpdatedObserver(
       AutomationProvider* provider,
       IPC::Message* reply_message,
-      bool wait_for_open);
+      bool wait_for_open,
+      Profile* profile);

[Randy Smith (Not in Mondays), 2012/08/02 17:52:17]

It looks like there's an observer created per download item it's needed for, so
it can be created with just the boolean as to whether or not the download item
is incognito.

[benjhayden, 2012/08/13 15:08:09]

Done.

   virtual ~AutomationProviderDownloadUpdatedObserver();
 
   virtual void OnDownloadUpdated(content::DownloadItem* download);
   virtual void OnDownloadOpened(content::DownloadItem* download);
 
  private:
   base::WeakPtr<AutomationProvider> provider_;
   scoped_ptr<IPC::Message> reply_message_;
   bool wait_for_open_;
+  Profile* profile_;
 
   DISALLOW_COPY_AND_ASSIGN(AutomationProviderDownloadUpdatedObserver);
 };
 
 // Allows the automation provider to wait until the download model has changed
 // (because a new download has been added or removed).
 class AutomationProviderDownloadModelChangedObserver
     : public content::DownloadManager::Observer {
  public:
   AutomationProviderDownloadModelChangedObserver(
@@ skipping 872 matching lines @@
   base::WeakPtr<AutomationProvider> automation_;
   scoped_ptr<IPC::Message> reply_message_;
   int new_window_id_;
   int num_loads_;
 
   DISALLOW_COPY_AND_ASSIGN(
       BrowserOpenedWithExistingProfileNotificationObserver);
 };
 
 #endif  // CHROME_BROWSER_AUTOMATION_AUTOMATION_PROVIDER_OBSERVERS_H_