Kill DownloadItem::IsOtr()

chrome/browser/automation/automation_provider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This implements a browser-side endpoint for UI automation activity.
 // The client-side endpoint is implemented by AutomationProxy.
 // The entire lifetime of this object should be contained within that of
 // the BrowserProcess, and in particular the NotificationService that's
 // hung off of it.
 
@@ skipping 138 matching lines @@
   }
 
 #if defined(OS_WIN) && !defined(USE_AURA)
   // Adds the external tab passed in to the tab tracker.
   bool AddExternalTab(ExternalTabContainer* external_tab);
 #endif
 
   // Get the DictionaryValue equivalent for a download item. Caller owns the
   // DictionaryValue.
   base::DictionaryValue* GetDictionaryFromDownloadItem(
-      const content::DownloadItem* download);
+      const content::DownloadItem* download,
+      Profile* profile);

[Randy Smith (Not in Mondays), 2012/08/02 17:52:17]

If you did this in response to my earlier comments, I'd like to apologize and
repent.  I think the code will be simpler (and lower level objects won't need to
know about Profiles) if you just pass around a boolean as to whether the
download item is incognito or not.

[benjhayden, 2012/08/13 15:08:09]

Done.

 
  protected:
   friend struct content::BrowserThread::DeleteOnThread<
       content::BrowserThread::UI>;
   friend class base::DeleteHelper<AutomationProvider>;
   virtual ~AutomationProvider();
 
   // Helper function to find the browser window that contains a given
   // NavigationController and activate that tab.
   // Returns the Browser if found.
@@ skipping 196 matching lines @@
   std::string channel_id_;
 
   // Trace data that has been collected but not flushed to the automation
   // client.
   TracingData tracing_data_;
 
   DISALLOW_COPY_AND_ASSIGN(AutomationProvider);
 };
 
 #endif  // CHROME_BROWSER_AUTOMATION_AUTOMATION_PROVIDER_H_