[Sync] Enable adding notifier observers from ProfileSyncService

sync/internal_api/public/sync_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_INTERNAL_API_PUBLIC_SYNC_MANAGER_H_
 #define SYNC_INTERNAL_API_PUBLIC_SYNC_MANAGER_H_
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/callback_forward.h"
 #include "base/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/task_runner.h"
 #include "base/threading/thread_checker.h"
 #include "base/time.h"
 #include "sync/internal_api/public/base/model_type.h"
 #include "sync/internal_api/public/change_record.h"
 #include "sync/internal_api/public/configure_reason.h"
 #include "sync/internal_api/public/engine/model_safe_worker.h"
 #include "sync/internal_api/public/engine/sync_status.h"
 #include "sync/internal_api/public/util/report_unrecoverable_error_function.h"
 #include "sync/internal_api/public/util/weak_handle.h"
+#include "sync/notifier/invalidation_util.h"
 #include "sync/protocol/sync_protocol_error.h"
 
-namespace syncer {
-class Encryptor;
-struct Experiments;
-class ExtensionsActivityMonitor;
-class InternalComponentsFactory;
-class JsBackend;
-class JsEventHandler;
-class SyncScheduler;
-class UnrecoverableErrorHandler;
-
-namespace sessions {
-class SyncSessionSnapshot;
-}  // namespace sessions
-}  // namespace syncer
-
-namespace syncer {
-class SyncNotifier;
-}  // namespace syncer
-
 namespace sync_pb {
 class EncryptedData;
 }  // namespace sync_pb
 
 namespace syncer {

[msw, 2012/08/03 05:14:21]

nit: if the syncer namespace contains more than just these forward decls, it
should probably have a blank line directly below it.

+class BaseTransaction;
+class Encryptor;
+struct Experiments;
+class ExtensionsActivityMonitor;
+class HttpPostProviderFactory;
+class InternalComponentsFactory;
+class JsBackend;
+class JsEventHandler;
+class SyncNotifier;
+class SyncNotifierObserver;
+class SyncScheduler;
+class UnrecoverableErrorHandler;
+struct UserShare;
 
-class BaseTransaction;
-class HttpPostProviderFactory;
-struct UserShare;
+namespace sessions {
+class SyncSessionSnapshot;
+}  // namespace sessions
 
 // Used by SyncManager::OnConnectionStatusChange().
 enum ConnectionStatus {
   CONNECTION_OK,
   CONNECTION_AUTH_ERROR,
   CONNECTION_SERVER_ERROR
 };
 
 // Reasons due to which Cryptographer might require a passphrase.
 enum PassphraseRequiredReason {
@@ skipping 339 matching lines @@
   // Returns false if an error occurred, true otherwise.
   virtual bool PurgePartiallySyncedTypes() = 0;
 
   // Update tokens that we're using in Sync. Email must stay the same.
   virtual void UpdateCredentials(const SyncCredentials& credentials) = 0;
 
   // Called when the user disables or enables a sync type.
   virtual void UpdateEnabledTypes(
       const ModelTypeSet& enabled_types) = 0;
 
+  // Forwards to the underlying notifier (see
+  // SyncNotifier::UpdateRegisteredIds()).
+  virtual void UpdateRegisteredInvalidationIds(
+      SyncNotifierObserver* handler, const ObjectIdSet& ids) = 0;

[msw, 2012/08/03 05:14:21]

The style guide dictates that these parameters should be on their own lines.

+
   // Put the syncer in normal mode ready to perform nudges and polls.
   virtual void StartSyncingNormally(
       const ModelSafeRoutingInfo& routing_info) = 0;
 
   // Attempts to re-encrypt encrypted data types using the passphrase provided.
   // Notifies observers of the result of the operation via OnPassphraseAccepted
   // or OnPassphraseRequired, updates the nigori node, and does re-encryption as
   // appropriate. If an explicit password has been set previously, we drop
   // subsequent requests to set a passphrase. If the cryptographer has pending
   // keys, and a new implicit passphrase is provided, we try decrypting the
@@ skipping 96 matching lines @@
   virtual bool ReceivedExperiment(Experiments* experiments) = 0;
 
   // Uses a read-only transaction to determine if the directory being synced has
   // any remaining unsynced items.  May be called on any thread.
   virtual bool HasUnsyncedItems() = 0;
 };
 
 }  // namespace syncer
 
 #endif  // SYNC_INTERNAL_API_PUBLIC_SYNC_MANAGER_H_