Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10804040: [Chromoting] Refactor the host policy watcher so that policies can easily be added. (Closed)

Created:
8 years, 5 months ago by simonmorris
Modified:
8 years, 5 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Refactor the host policy watcher so that policies can easily be added. This CL renames some classes, but not the source files, to make it easier to compare the old and new versions. A follow-up CL will rename the files. BUG=137906 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148029

Patch Set 1 #

Patch Set 2 : Change array size definitions. #

Patch Set 3 : Fix Windows. #

Patch Set 4 : Pass the policy dictionary as a scoped_ptr. #

Total comments: 4

Patch Set 5 : Rename files. #

Patch Set 6 : Fix for Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+596 lines, -837 lines) Patch
M remoting/host/plugin/host_script_object.h View 1 2 3 3 chunks +5 lines, -2 lines 0 comments Download
M remoting/host/plugin/host_script_object.cc View 1 2 3 4 4 chunks +27 lines, -10 lines 0 comments Download
A remoting/host/policy_hack/fake_policy_watcher.h View 1 2 3 4 1 chunk +30 lines, -0 lines 0 comments Download
A remoting/host/policy_hack/fake_policy_watcher.cc View 1 2 3 4 1 chunk +34 lines, -0 lines 0 comments Download
A remoting/host/policy_hack/mock_policy_callback.h View 1 2 3 4 5 1 chunk +31 lines, -0 lines 0 comments Download
A remoting/host/policy_hack/mock_policy_callback.cc View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M remoting/host/policy_hack/nat_policy.h View 1 2 3 4 1 chunk +0 lines, -79 lines 0 comments Download
M remoting/host/policy_hack/nat_policy.cc View 1 2 3 4 1 chunk +0 lines, -112 lines 0 comments Download
M remoting/host/policy_hack/nat_policy_linux.cc View 1 2 3 4 1 chunk +0 lines, -278 lines 0 comments Download
M remoting/host/policy_hack/nat_policy_mac.mm View 1 2 3 4 1 chunk +0 lines, -72 lines 0 comments Download
M remoting/host/policy_hack/nat_policy_win.cc View 1 2 3 4 1 chunk +0 lines, -186 lines 0 comments Download
A + remoting/host/policy_hack/policy_watcher.h View 1 2 3 4 3 chunks +31 lines, -23 lines 0 comments Download
A remoting/host/policy_hack/policy_watcher.cc View 1 2 3 4 1 chunk +163 lines, -0 lines 0 comments Download
A + remoting/host/policy_hack/policy_watcher_linux.cc View 1 2 3 4 10 chunks +25 lines, -25 lines 0 comments Download
A + remoting/host/policy_hack/policy_watcher_mac.mm View 1 2 3 4 3 chunks +21 lines, -17 lines 0 comments Download
A remoting/host/policy_hack/policy_watcher_unittest.cc View 1 2 3 4 1 chunk +150 lines, -0 lines 0 comments Download
A + remoting/host/policy_hack/policy_watcher_win.cc View 1 2 3 4 7 chunks +22 lines, -18 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 3 4 6 chunks +25 lines, -10 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 4 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
simonmorris
ptal
8 years, 5 months ago (2012-07-19 23:54:23 UTC) #1
garykac
LGTM if you rename the files to match the classnames. http://codereview.chromium.org/10804040/diff/11002/remoting/host/policy_hack/nat_policy.cc File remoting/host/policy_hack/nat_policy.cc (right): http://codereview.chromium.org/10804040/diff/11002/remoting/host/policy_hack/nat_policy.cc#newcode70 ...
8 years, 5 months ago (2012-07-23 17:29:26 UTC) #2
simonmorris
fyi http://codereview.chromium.org/10804040/diff/11002/remoting/host/policy_hack/nat_policy.cc File remoting/host/policy_hack/nat_policy.cc (right): http://codereview.chromium.org/10804040/diff/11002/remoting/host/policy_hack/nat_policy.cc#newcode70 remoting/host/policy_hack/nat_policy.cc:70: const char* const PolicyWatcher::kBooleanPolicyNames[] = On 2012/07/23 17:29:26, ...
8 years, 5 months ago (2012-07-23 19:34:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10804040/9003
8 years, 5 months ago (2012-07-23 19:35:09 UTC) #4
commit-bot: I haz the power
Try job failure for 10804040-9003 (retry) on win for step "runhooks". It's a second try, ...
8 years, 5 months ago (2012-07-23 19:48:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10804040/9003
8 years, 5 months ago (2012-07-23 20:20:30 UTC) #6
commit-bot: I haz the power
Try job failure for 10804040-9003 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-23 21:17:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10804040/13015
8 years, 5 months ago (2012-07-23 23:01:56 UTC) #8
commit-bot: I haz the power
Try job failure for 10804040-13015 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-24 00:25:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10804040/13015
8 years, 5 months ago (2012-07-24 00:28:37 UTC) #10
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 01:56:55 UTC) #11 
Change committed as 148029

Powered by Google App Engine
This is Rietveld 408576698