Extensions Docs Server: Internationalized samples

chrome/common/extensions/docs/server2/intro_data_source.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from HTMLParser import HTMLParser
 
 from path_utils import FormatKey
 from third_party.handlebar import Handlebar
@@ skipping 29 matching lines @@
     if tag in ['h1', 'h2', 'h3']:
       self._recent_tag = None
 
   def handle_data(self, data):
     if self._recent_tag is None:
       return
     if self._recent_tag == 'h1':
       if self.page_title is None:
         self.page_title = data
       else:
         self.page_title += data

[not at google - send to devlin, 2012/07/25 01:44:14]

see previous comment about this?

(i.e. remove else clause)

[cduvall, 2012/07/25 03:19:26]

The else clause is needed because sometimes the data is split up in weird ways
by the HTMLParser. Only the first h1 will be taken as the page title though (see
line 27). All the other h1 tags are ignored once the title is set.

     elif self._recent_tag in ['h2', 'h3']:
       self._current_heading['title'] += data
 
 class IntroDataSource(object):
   """This class fetches the intros for a given API. From this intro, a table
   of contents dictionary is created, which contains the headings in the intro.
   """
   def __init__(self, cache_builder, base_paths):
     self._cache = cache_builder.build(self._MakeIntroDict)
     self._base_paths = base_paths
 
   def _MakeIntroDict(self, intro):
-    try:
-      parser = _IntroParser()
-      parser.feed(intro)
-      return {
-        'intro': Handlebar(intro),
-        'toc': parser.toc,
-        'title': parser.page_title
-      }
-    except Exception as e:
-      logging.info(e)
+    parser = _IntroParser()
+    parser.feed(intro)
+    return {
+      'intro': Handlebar(intro),
+      'toc': parser.toc,
+      'title': parser.page_title
+    }
 
   def __getitem__(self, key):
     return self.get(key)
 
   def get(self, key):
     real_path = FormatKey(key)
     for base_path in self._base_paths:
       try:
         return self._cache.GetFromFile(base_path + '/' + real_path)
       except Exception:
         pass
     return None