chrome/browser/ui/views/select_file_dialog_extension_unittest.cc - Issue 10804026: Fix open dialog not remembering last opened folder on drive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension_unittest.cc

Issue 10804026: Fix open dialog not remembering last opened folder on drive (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/select_file_dialog_extension_unittest.cc

diff --git a/chrome/browser/ui/views/select_file_dialog_extension_unittest.cc b/chrome/browser/ui/views/select_file_dialog_extension_unittest.cc

index cc405305357718866cf5b8c752b20c2bc9d70b38..9362327a9c02e82fa5e3cb1d806941160ae3d44e 100644

--- a/chrome/browser/ui/views/select_file_dialog_extension_unittest.cc

+++ b/chrome/browser/ui/views/select_file_dialog_extension_unittest.cc

@@ -53,7 +53,7 @@ TEST_F(SelectFileDialogExtensionTest, SelfDeleting) {

SelfDeletingClient* client = new SelfDeletingClient(kTabId);

// Ensure we don't crash or trip an Address Sanitizer warning about

// use-after-free.

- ui::SelectedFileInfo file_info;

+ ui::SelectedFileInfo file_info = ui::SelectedFileInfo(FilePath(), FilePath());

achuithb 2012/07/24 20:13:05 Why is this necessary? It seems like the default c

tbarzic 2012/07/25 02:02:54 Done.

SelectFileDialogExtension::OnFileSelected(kTabId, file_info, 0);

// Simulate closing the dialog so the listener gets invoked.

client->dialog()->ExtensionDialogClosing(NULL);