Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java

Issue 10804003: Android: fix test runners for non-rooted devices. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Uses external storage Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java
diff --git a/testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java b/testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java
index ad3bab4a8118fcb78cf776a5c64984eb2e474949..61bfbc420ed1d5da45292fadd3a94a9a210760c9 100644
--- a/testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java
+++ b/testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java
@@ -7,11 +7,14 @@ package org.chromium.native_test;
import android.app.Activity;
import android.content.Context;
import android.os.Bundle;
+import android.os.Environment;
import android.os.Handler;
import android.util.Log;
import org.chromium.base.PathUtils;
+import java.io.File;
+
// Android's NativeActivity is mostly useful for pure-native code.
// Our tests need to go up to our own java classes, which is not possible using
// the native activity class loader.
@@ -67,7 +70,10 @@ public class ChromeNativeTestActivity extends Activity {
private void runTests() {
Log.d(TAG, ">>nativeRunTests");
- nativeRunTests(getFilesDir().getAbsolutePath(), getApplicationContext());
+ File filesDir = new File(Environment.getExternalStorageDirectory(),
John Grabowski 2012/07/18 20:40:49 Add reference to test_package_apk.py
bulach 2012/07/19 08:14:33 good point! done.
+ "native_tests/");
+ filesDir.mkdirs();
+ nativeRunTests(filesDir.getAbsolutePath(), getApplicationContext());
Log.d(TAG, "<<nativeRunTests");
}
« build/android/pylib/test_package_apk.py ('K') | « testing/android/AndroidManifest.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698