Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5360)

Unified Diff: build/android/pylib/test_package_apk.py

Issue 10804003: Android: fix test runners for non-rooted devices. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Uses external storage Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/test_package_apk.py
diff --git a/build/android/pylib/test_package_apk.py b/build/android/pylib/test_package_apk.py
index a5fbf6b344dc556a40a7ac0c5e7e5d27fdd83c23..3cb287cbdc9dc19760b50d249afc63f874d100ae 100644
--- a/build/android/pylib/test_package_apk.py
+++ b/build/android/pylib/test_package_apk.py
@@ -29,8 +29,6 @@ class TestPackageApk(TestPackage):
dump_debug_info: A debug_info object.
"""
- APK_DATA_DIR = '/data/user/0/org.chromium.native_test/files/'
-
def __init__(self, adb, device, test_suite, timeout, rebaseline,
performance_test, cleanup_test_files, tool,
dump_debug_info):
@@ -69,8 +67,7 @@ class TestPackageApk(TestPackage):
# Copy stdout.txt and read contents.
stdout_file = tempfile.NamedTemporaryFile()
ret = []
- self.adb.Adb().Pull(TestPackageApk.APK_DATA_DIR + 'stdout.txt',
- stdout_file.name)
+ self.adb.Adb().Pull('/sdcard/native_tests/stdout.txt', stdout_file.name)
John Grabowski 2012/07/18 20:40:49 Prefer string const higher in the class (like befo
bulach 2012/07/19 08:14:33 Done.
# We need to strip the trailing newline.
content = [line.rstrip() for line in open(stdout_file.name)]
ret = self._ParseGTestListTests(content)

Powered by Google App Engine
This is Rietveld 408576698