Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: content/test/content_browser_test.cc

Issue 10803026: Get content_browsertest working. I've added a simple test for now, and will convert the tests in sr… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/content_browser_test.cc
===================================================================
--- content/test/content_browser_test.cc (revision 147044)
+++ content/test/content_browser_test.cc (working copy)
@@ -5,6 +5,7 @@
#include "content/test/content_browser_test.h"
#include "base/debug/stack_trace.h"
+#include "base/logging.h"
#include "base/message_loop.h"
#include "content/shell/shell.h"
#include "content/shell/shell_main_delegate.h"
@@ -21,7 +22,6 @@
}
void ContentBrowserTest::SetUp() {
- DCHECK(!content::GetContentClient());
shell_main_delegate_.reset(new ShellMainDelegate);
shell_main_delegate_->PreSandboxStartup();
@@ -45,6 +45,9 @@
#endif // defined(OS_POSIX)
void ContentBrowserTest::RunTestOnMainThreadLoop() {
+ CHECK_EQ(content::Shell::GetWindows().size(), 1u);
+ shell_ = content::Shell::GetWindows()[0];
+
#if defined(OS_POSIX)
signal(SIGTERM, DumpStackTraceSignalHandler);
#endif // defined(OS_POSIX)
@@ -71,9 +74,4 @@
#if defined(OS_MACOSX)
pool.Recycle();
#endif
-
- MessageLoopForUI::current()->Quit();
-#if defined(OS_MACOSX)
- pool.Recycle();
-#endif
}

Powered by Google App Engine
This is Rietveld 408576698