chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc - Issue 10803026: Get content_browsertest working. I've added a simple test for now, and will convert the tests in sr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc

Issue 10803026: Get content_browsertest working. I've added a simple test for now, and will convert the tests in sr… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: get it working on mac + linux, fix unittests crash, and fix unittest link error and add missing dep… Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc

===================================================================

--- chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc (revision 147044)

+++ chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc (working copy)

@@ -8,9 +8,9 @@

#include "base/bind.h"

#include "base/bind_helpers.h"

#include "base/message_loop.h"

+#include "base/run_loop.h"

#include "base/utf_string_conversions.h"

#include "chrome/common/render_messages.h"

-#include "chrome/test/base/ui_test_utils.h"

#include "content/public/browser/plugin_service.h"

#include "content/public/browser/plugin_service_filter.h"

#include "content/public/test/test_browser_thread.h"

@@ -91,7 +91,8 @@

PluginService::GetInstance()->GetPlugins(

base::Bind(&PluginInfoMessageFilterTest::PluginsLoaded,

base::Unretained(this)));

- ui_test_utils::RunMessageLoop();

+ base::RunLoop run_loop;

+ run_loop.Run();

}

protected:

« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »