Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 10802074: Update the toast strings for the new experiment (Closed)

Created:
8 years, 5 months ago by cpu_(ooo_6.6-7.5)
Modified:
8 years, 5 months ago
Reviewers:
Finnur
CC:
chromium-reviews
Visibility:
Public.

Description

Update the toast strings for the new experiment - Adds an extra checkbox, see bug. BUG=129499 TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
8 years, 5 months ago (2012-07-23 20:17:08 UTC) #1
cpu_(ooo_6.6-7.5)
it is unclear finnur still works at google. I think a dingo got him.
8 years, 5 months ago (2012-07-25 01:18:18 UTC) #2
Finnur
I fought long and hard with the beast, getting the better of it in sword ...
8 years, 5 months ago (2012-07-25 10:41:25 UTC) #3
cpu_(ooo_6.6-7.5)
8 years, 5 months ago (2012-07-25 17:53:21 UTC) #4
sgtm. stand by for CL.


On 2012/07/25 10:41:25, Finnur wrote:
> I fought long and hard with the beast, getting the better of it in sword
> fighting but narrowly loosing out on points in kick boxing. It came down to a
> battle of wits, where I managed to thread an apple through the eye of a needle
> using only a pair of pliers and some talcum powder. We won't be seeing the
beast
> again.
> 
> On to more mundane things. My only question is why add this as a string in two
> files and not one string in one file (generated_resources.grd)? There doesn't
> seem to be any difference in these two strings... If you were thinking of the
> desc field (chrome vs chromium) then I think you don't need to use these files
> for those (they are just comments).

Powered by Google App Engine
This is Rietveld 408576698