Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Unified Diff: chrome/browser/favicon/favicon_handler.cc

Issue 10802066: Adds support for saving favicon size into history database. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_handler.cc
diff --git a/chrome/browser/favicon/favicon_handler.cc b/chrome/browser/favicon/favicon_handler.cc
index 41d388c6c8417b5554ef712635583daf6d25cbd0..80c4883a40fa7f91a58cf4e215da9c9f015678c8 100644
--- a/chrome/browser/favicon/favicon_handler.cc
+++ b/chrome/browser/favicon/favicon_handler.cc
@@ -417,7 +417,7 @@ void FaviconHandler::OnFaviconDataForInitialURL(
// user doesn't see a flash of the default favicon.
entry->GetFavicon().url = favicon.icon_url;
if (favicon.is_valid())
- UpdateFavicon(entry, favicon.image_data);
+ UpdateFavicon(entry, favicon.bitmap_data);
entry->GetFavicon().valid = true;
}
@@ -485,7 +485,7 @@ void FaviconHandler::OnFaviconData(FaviconService::Handle handle,
// There is a favicon, set it now. If expired we'll download the current
// one again, but at least the user will get some icon instead of the
// default and most likely the current one is fine anyway.
- UpdateFavicon(entry, favicon.image_data);
+ UpdateFavicon(entry, favicon.bitmap_data);
}
if (!favicon.known_icon || favicon.expired) {
// We don't know the favicon, or it is out of date. Request the current

Powered by Google App Engine
This is Rietveld 408576698